fixes binary checksum validation and binary naming in releases

[copejon]

Which issue(s) this PR addresses:
The install.sh should not change the name of the binary before calculating its checksum.

Closes #203

[rootfs]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rootfs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rootfs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[oglok]

@copejon @rootfs IIUC, checksums are performed on the content of the file to be checked, and not its name.

~# sha256sum microshift
6ce3a6e4871f4ba46f68062af696974cba8b37cb1306b9c84b7049053afe2f2f  microshift
~# mv microshift whatever
~# sha256sum whatever 
6ce3a6e4871f4ba46f68062af696974cba8b37cb1306b9c84b7049053afe2f2f  whatever

The install script was written before the addition of the ARM checksum to the release.sha256 file. It'd cool to have the ARM case considered in the install script as well (even thought it's not working at this moment).

[copejon]

It'd cool to have the ARM case considered in the install script as well (even thought it's not working at this moment).

I agree, but I think we can leave that to another PR as it'll either change or append to the script UX.

checksums are performed on the content of the file to be checked, and not its name.

Yeah, this is true - the reason to rename after comparing checksums is that we need to match the download artifact to its checksum by name. So the script now first looks it up by it's name, then renames it to microshift.