Skip to content

WIP POC MicroShift e2e using robot framework#1635

Closed
pmtk wants to merge 39 commits intoopenshift:mainfrom
pmtk:robot-framework
Closed

WIP POC MicroShift e2e using robot framework#1635
pmtk wants to merge 39 commits intoopenshift:mainfrom
pmtk:robot-framework

Conversation

@pmtk
Copy link
Member

@pmtk pmtk commented Apr 7, 2023

See most recent commit

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2023
@openshift-ci openshift-ci bot requested review from dhellmann and pacevedom April 7, 2023 12:37
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can run .venv/bin/python3 -m pip without activating the environment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, if you run .venv/bin/robot it should work without activating the environment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IP could come from running ./scripts/devenv-builder/manage-vm.sh ip

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it could also be passed via ENV vars or other means. I just hardcoded it to reduce typing when PoCing this :)
Not tying it to other scripts can result in scalability - run whatever test suite you want against any VM in parallel.

In regards to ostree upgrade/rollback I have this idea (not sure how it'll pan out):
if we go with "nested virt" approach, then we could setup a job (sanity periodic most likely) that would spawn multiple nested VMs and do some testing in parallel.
Like this mad idea: build 4.14.0 base image (as in qemu backing image, so new VMs can be spawned quickly) and do upgrades (rather by installing new RPMs than preparing whole new image)

 .0 ----
 |  \    \
.1   .2   .3
 |    |
.2   .3
 |
.3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these paths relative to the directory where someone runs robot, or to the location of the .robot file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's relative to current working dir which, when running make inside e2e-robot, is e2e-robot/

@pmtk pmtk force-pushed the robot-framework branch from 37f8e3c to 5903582 Compare April 8, 2023 11:26
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 8, 2023

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants