Skip to content

[release-4.13] OCPBUGS-10243: update sysconfwatch-controller logging#1630

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
openshift-cherrypick-robot:cherry-pick-1445-to-release-4.13
Apr 10, 2023
Merged

[release-4.13] OCPBUGS-10243: update sysconfwatch-controller logging#1630
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
openshift-cherrypick-robot:cherry-pick-1445-to-release-4.13

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 6, 2023

This is an automated cherry-pick of #1445

/assign dhellmann

@dhellmann
OCPBUGS-8329: update sysconfwatch-controller logging
6c7b4b8 
There is no need to log the gateway IP address every time we look it
up, so only log it when it changes. This is somewhat redundant to the
logic in the controller itself, but the IP returned from GetHostIP()
is not always the gateway IP and GetHostIP() may have other callers.

This change also rewords another log message related to how the host
IP is being selected to make it clear what effect the failure to find
a default route has on the outcome.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 6, 2023
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 6, 2023

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-8329 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.13] OCPBUGS-10243: update sysconfwatch-controller logging

Details

In response to this:

This is an automated cherry-pick of #1445

/assign dhellmann

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-8329: update sysconfwatch-controller logging [release-4.13] OCPBUGS-10243: update sysconfwatch-controller logging Apr 6, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.13] OCPBUGS-10243: update sysconfwatch-controller logging

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 6, 2023

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-10243, which is invalid:

  • expected the bug to be open, but it isn't
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Won't Do) instead
  • expected Jira Issue OCPBUGS-10243 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1445

/assign dhellmann

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from ggiguash and sallyom April 6, 2023 19:48
@dhellmann
Copy link
Contributor

dhellmann commented Apr 6, 2023

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 6, 2023

@dhellmann: This pull request references Jira Issue OCPBUGS-10243, which is invalid:

  • expected Jira Issue OCPBUGS-10243 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
Copy link
Contributor

dhellmann commented Apr 6, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 6, 2023

@dhellmann: This pull request references Jira Issue OCPBUGS-10243, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-8329 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-8329 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @jogeo

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jogeo April 6, 2023 19:52
@dhellmann
Copy link
Contributor

dhellmann commented Apr 6, 2023

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 6, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2023
@dhellmann
Copy link
Contributor

dhellmann commented Apr 8, 2023

/retest-required

@ggiguash
Copy link
Contributor

ggiguash commented Apr 9, 2023

/retest

@jogeo
Copy link
Contributor

jogeo commented Apr 10, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 10, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6941e71 into openshift:release-4.13 Apr 10, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 10, 2023

@openshift-cherrypick-robot: Jira Issue OCPBUGS-10243: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-10243 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #1445

/assign dhellmann

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced May 7, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggiguash ggiguash Awaiting requested review from ggiguash

@sallyom sallyom Awaiting requested review from sallyom

@jogeo jogeo Awaiting requested review from jogeo

Assignees

@dhellmann dhellmann

@mffiedler mffiedler

@jhou1 jhou1

@zhaozhanqi zhaozhanqi

@jogeo jogeo

@xingxingxia xingxingxia

@anuragthehatter anuragthehatter

@wangke19 wangke19

@pacevedom pacevedom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.