OCPBUGS-8329: update sysconfwatch-controller logging

[dhellmann]

There is no need to log the gateway IP address every time we look it
up, so only log it when it changes. This is somewhat redundant to the
logic in the controller itself, but the IP returned from GetHostIP()
is not always the gateway IP and GetHostIP() may have other callers.

This change also rewords another log message related to how the host
IP is being selected to make it clear what effect the failure to find
a default route has on the outcome.

[openshift-ci-robot]

@dhellmann: This pull request references Jira Issue OCPBUGS-8329, which is invalid:

• expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

There is no need to log the gateway IP address every time we look it
up, so only log it when it changes. This is somewhat redundant to the
logic in the controller itself, but the IP returned from GetHostIP()
is not always the gateway IP and GetHostIP() may have other callers.

This change also rewords another log message related to how the host
IP is being selected to make it clear what effect the failure to find
a default route has on the outcome.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dhellmann]

/jira refresh

[openshift-ci-robot]

@dhellmann: This pull request references Jira Issue OCPBUGS-8329, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dhellmann]

/retest-required

[ggiguash]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dhellmann,ggiguash]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@dhellmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@dhellmann: Jira Issue OCPBUGS-8329: All pull requests linked via external trackers have merged:

• openshift/microshift#1445

Jira Issue OCPBUGS-8329 has been moved to the MODIFIED state.

Details

In response to this:

There is no need to log the gateway IP address every time we look it
up, so only log it when it changes. This is somewhat redundant to the
logic in the controller itself, but the IP returned from GetHostIP()
is not always the gateway IP and GetHostIP() may have other callers.

This change also rewords another log message related to how the host
IP is being selected to make it clear what effect the failure to find
a default route has on the outcome.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dhellmann]

/cherry-pick release-4.13

[openshift-cherrypick-robot]

@dhellmann: new pull request created: #1630

Details

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.