Skip to content

[release-4.13] OCPBUGS-8338: Adding etcd config to user-facing config#1441

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
openshift-cherrypick-robot:cherry-pick-1435-to-release-4.13
Mar 7, 2023
Merged

[release-4.13] OCPBUGS-8338: Adding etcd config to user-facing config#1441
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
openshift-cherrypick-robot:cherry-pick-1435-to-release-4.13

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #1435

/assign dusk125

@dhellmann
Copy link
Contributor

/lgtm

@dusk125
Copy link
Contributor

dusk125 commented Mar 3, 2023

/assign @dhellmann @pmtk

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2023
@dhellmann
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2023
@dhellmann
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ggiguash
Copy link
Contributor

ggiguash commented Mar 5, 2023

/retitle [release-4.13] OCPBUGS-8338: Adding etcd config to user-facing config

@openshift-ci openshift-ci bot changed the title [release-4.13] ETCD-401: Adding etcd config to user-facing config [release-4.13] OCPBUGS-8338: Adding etcd config to user-facing config Mar 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 5, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.13] OCPBUGS-8338: Adding etcd config to user-facing config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 5, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-8338, which is invalid:

  • expected Jira Issue OCPBUGS-8338 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1435

/assign dusk125

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Contributor

ggiguash commented Mar 5, 2023

/label bugzilla/valid-bug
/label cherry-pick-approved

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 5, 2023

@ggiguash: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

/label bugzilla/valid-bug
/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann dhellmann added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 6, 2023
@dhellmann
Copy link
Contributor

This work went into 4.14 as part of a story, and is being backported so the changes are complete in 4.13. I've updated the jira labels to reflect that.

@jogeo, this should be ready for QE evaluation.

@jogeo
Copy link
Contributor

jogeo commented Mar 7, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit cb48233 into openshift:release-4.13 Mar 7, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-8338: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-8338 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #1435

/assign dusk125

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.