Skip to content

ETCD-401: Adding etcd config to user-facing config#1435

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dusk125:etcd-config
Mar 3, 2023
Merged

ETCD-401: Adding etcd config to user-facing config#1435
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dusk125:etcd-config

Conversation

@dusk125
Copy link
Contributor

@dusk125 dusk125 commented Mar 2, 2023

#1395 Added etcd configuration to the internal Microshift config structure, but not the user-facing configuration. This PR adds the etcd config to the user-facing configuration file.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2023
@dusk125
Copy link
Contributor Author

dusk125 commented Mar 2, 2023

/assign @pmtk @dhellmann

@openshift-ci openshift-ci bot requested review from copejon and pmtk March 2, 2023 14:16
@ggiguash
Copy link
Contributor

ggiguash commented Mar 2, 2023

@dusk125 , if we are making this change, we need to also update the following files:

@dusk125 dusk125 force-pushed the etcd-config branch 2 times, most recently from d08e933 to d38090e Compare March 2, 2023 14:49
@dusk125
Copy link
Contributor Author

dusk125 commented Mar 2, 2023

/retest

@dusk125 dusk125 changed the title WIP: Adding etcd config to user-facing config ETCD-401: Adding etcd config to user-facing config Mar 2, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 2, 2023

@dusk125: This pull request references ETCD-401 which is a valid jira issue.

Details

In response to this:

#1395 Added etcd configuration to the internal Microshift config structure, but not the user-facing configuration. This PR adds the etcd config to the user-facing configuration file.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2023
@dhellmann
Copy link
Contributor

/approve

/assign @pmtk

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2023
@dusk125
Copy link
Contributor Author

dusk125 commented Mar 3, 2023

/cherry-pick release-4.13

@openshift-cherrypick-robot

@dusk125: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk
Copy link
Member

pmtk commented Mar 3, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, dusk125, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cf0bce2 and 2 for PR HEAD 99a6ce9 in total

@dusk125
Copy link
Contributor Author

dusk125 commented Mar 3, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2023

@dusk125: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-cherrypick-robot

@dusk125: new pull request created: #1441

Details

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants