OCPBUGS-6908: 4.12 Avoid firewalld flush of iptables by mangelajo · Pull Request #1309 · openshift/microshift

mangelajo · 2023-01-31T14:22:12Z

cherry pick from #1300 (automatic cherry
pick failed with conflict on the microshift.spec file changelog entries)

Avoid firewalld flush of iptables

https://issues.redhat.com/browse/NP-641
https://issues.redhat.com/browse/USHIFT-789
https://issues.redhat.com/browse/OCPBUGS-6860

Disables firewalld access to iptables related nftables translator, this avoids firewalld flush of iptables under any circumstance, firewalld will work at nftables level, while MicroShift/OVN can continue to work at iptables level (translated to nft) under the hood. (cherry picked from commit f51d031)

openshift-ci · 2023-01-31T14:22:16Z

@mangelajo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

4.12 Avoid firewalld flush of iptables

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dhellmann · 2023-01-31T16:20:41Z

If the automated cherry-pick had been successful, I think it would have cloned the bug for you, too. I think you'll have to do that by hand now, though to have a valid Jira ticket.

dhellmann · 2023-01-31T21:04:14Z

@jogeo do you have enough information to create a test plan for this PR?

mangelajo · 2023-02-01T11:51:00Z

That was my next question, so I need to clone the JIRA ticket and target it to 4.12 I guess, let me try that. I am still not familiar enough to do it by heart.

openshift-ci · 2023-02-01T11:51:44Z

@mangelajo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

4.12 Avoid firewalld flush of iptables

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mangelajo · 2023-02-01T11:52:05Z

@dhellmann but https://issues.redhat.com/browse/OCPBUGS-6860 is targeted to 4.12, do I need anything in addition to that?

openshift-ci · 2023-02-01T11:52:39Z

@mangelajo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

BUG OCPBUGS-6860 4.12 Avoid firewalld flush of iptables

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mangelajo · 2023-02-01T11:52:45Z

/bugzilla refresh

openshift-ci · 2023-02-01T11:52:48Z

@mangelajo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-02-01T11:53:27Z

@mangelajo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Bug OCPBUGS-6860 4.12 Avoid firewalld flush of iptables

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-02-01T11:54:17Z

@mangelajo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-6860: 4.12 Avoid firewalld flush of iptables

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-02-01T11:54:19Z

@mangelajo: This pull request references Jira Issue OCPBUGS-6860, which is invalid:

expected the bug to target the "4.12.z" version, but no target version was set
expected Jira Issue OCPBUGS-6860 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

cherry pick from #1300 (automatic cherry
pick failed with conflict on the microshift.spec file changelog entries)

Avoid firewalld flush of iptables

https://issues.redhat.com/browse/NP-641
https://issues.redhat.com/browse/USHIFT-789
https://issues.redhat.com/browse/OCPBUGS-6860

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mangelajo · 2023-02-01T11:55:15Z

/jira refresh

openshift-ci-robot · 2023-02-01T11:55:18Z

@mangelajo: This pull request references Jira Issue OCPBUGS-6860, which is invalid:

expected Jira Issue OCPBUGS-6860 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-02-01T11:58:20Z

@mangelajo: This pull request references Jira Issue OCPBUGS-6908, which is invalid:

expected dependent Jira Issue OCPBUGS-6860 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is New instead
expected dependent Jira Issue OCPBUGS-6860 to target a version in 4.13.0, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

cherry pick from #1300 (automatic cherry
pick failed with conflict on the microshift.spec file changelog entries)

Avoid firewalld flush of iptables

https://issues.redhat.com/browse/NP-641
https://issues.redhat.com/browse/USHIFT-789
https://issues.redhat.com/browse/OCPBUGS-6860

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-02-01T11:58:21Z

@mangelajo: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-6908: 4.12 Avoid firewalld flush of iptables

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mangelajo · 2023-02-01T12:02:00Z

/jira refresh

openshift-ci-robot · 2023-02-01T12:02:07Z

@mangelajo: This pull request references Jira Issue OCPBUGS-6908, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.z) matches configured target version for branch (4.12.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-6860 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-6860 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
bug has dependents

Requesting review from QA contact:
/cc @jogeo

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jogeo · 2023-02-01T18:06:07Z

@dhellmann The original issue was easy to recreate and surfaced by a couple existing test cases. So, QE has the all the test plan information we need.

dhellmann · 2023-02-01T22:41:50Z

Thanks, @jogeo. Handing this off to QE, then.

/label backport-risk-assessed
/lgtm

ggiguash · 2023-02-05T16:39:58Z

/retest

zshi-redhat · 2023-02-08T00:22:07Z

/retest

dhellmann · 2023-02-09T17:35:33Z

/lgtm

openshift-ci · 2023-02-09T17:37:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, mangelajo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dhellmann,mangelajo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2023-02-09T18:16:20Z

@mangelajo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jogeo · 2023-02-09T20:20:33Z

/label cherry-pick-approved

openshift-ci-robot · 2023-02-09T20:25:53Z

@mangelajo: Jira Issue OCPBUGS-6908 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

Details

In response to this:

cherry pick from #1300 (automatic cherry
pick failed with conflict on the microshift.spec file changelog entries)

Avoid firewalld flush of iptables

https://issues.redhat.com/browse/NP-641
https://issues.redhat.com/browse/USHIFT-789
https://issues.redhat.com/browse/OCPBUGS-6860

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from oglok and sallyom January 31, 2023 14:23

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2023

mangelajo requested review from ggiguash, pacevedom and pmtk January 31, 2023 15:56

mangelajo changed the title ~~4.12 Avoid firewalld flush of iptables~~ BUG OCPBUGS-6860 4.12 Avoid firewalld flush of iptables Feb 1, 2023

mangelajo changed the title ~~BUG OCPBUGS-6860 4.12 Avoid firewalld flush of iptables~~ Bug OCPBUGS-6860 4.12 Avoid firewalld flush of iptables Feb 1, 2023

mangelajo changed the title ~~Bug OCPBUGS-6860 4.12 Avoid firewalld flush of iptables~~ OCPBUGS-6860: 4.12 Avoid firewalld flush of iptables Feb 1, 2023

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 1, 2023

mangelajo changed the title ~~OCPBUGS-6860: 4.12 Avoid firewalld flush of iptables~~ OCPBUGS-6908: 4.12 Avoid firewalld flush of iptables Feb 1, 2023

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 1, 2023

openshift-ci bot requested a review from jogeo February 1, 2023 12:02

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 1, 2023

openshift-ci bot assigned anuragthehatter, jhou1, jogeo, mffiedler, wangke19, xingxingxia, zhaozhanqi and dhellmann Feb 1, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2023

Merge branch 'release-4.12' into backport-USHIFT-789

3c7b3a1

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2023

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 9, 2023

openshift-merge-robot merged commit 932074d into openshift:release-4.12 Feb 9, 2023

zshi-redhat mentioned this pull request Feb 13, 2023

OSDOCS-5274: Restart node when changing mtu value openshift/openshift-docs#55763

Merged

1 task

Conversation

mangelajo commented Jan 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Jan 31, 2023

Uh oh!

dhellmann commented Jan 31, 2023

Uh oh!

dhellmann commented Jan 31, 2023

Uh oh!

mangelajo commented Feb 1, 2023

Uh oh!

openshift-ci bot commented Feb 1, 2023

Uh oh!

mangelajo commented Feb 1, 2023

Uh oh!

openshift-ci bot commented Feb 1, 2023

Uh oh!

mangelajo commented Feb 1, 2023

Uh oh!

openshift-ci bot commented Feb 1, 2023

Uh oh!

openshift-ci bot commented Feb 1, 2023

Uh oh!

openshift-ci bot commented Feb 1, 2023

Uh oh!

openshift-ci-robot commented Feb 1, 2023

Uh oh!

mangelajo commented Feb 1, 2023

Uh oh!

openshift-ci-robot commented Feb 1, 2023

Uh oh!

openshift-ci-robot commented Feb 1, 2023

Uh oh!

openshift-ci bot commented Feb 1, 2023

Uh oh!

mangelajo commented Feb 1, 2023

Uh oh!

openshift-ci-robot commented Feb 1, 2023

Uh oh!

jogeo commented Feb 1, 2023

Uh oh!

dhellmann commented Feb 1, 2023

Uh oh!

ggiguash commented Feb 5, 2023

Uh oh!

zshi-redhat commented Feb 8, 2023

Uh oh!

dhellmann commented Feb 9, 2023

Uh oh!

openshift-ci bot commented Feb 9, 2023

Uh oh!

openshift-ci bot commented Feb 9, 2023

Uh oh!

jogeo commented Feb 9, 2023

Uh oh!

openshift-ci-robot commented Feb 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

mangelajo commented Jan 31, 2023 •

edited

Loading