Skip to content

OSDOCS-5274: Restart node when changing mtu value#55763

Merged
jboxman-rh merged 1 commit intoopenshift:mainfrom
ShaunaDiaz:OSDOCS-5274
Feb 17, 2023
Merged

OSDOCS-5274: Restart node when changing mtu value#55763
jboxman-rh merged 1 commit intoopenshift:mainfrom
ShaunaDiaz:OSDOCS-5274

Conversation

@ShaunaDiaz
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz commented Feb 9, 2023 •
edited
Loading

Version(s):
4.12, 4.13

Issue:
https://issues.redhat.com/browse/OSDOCS-5274

Link to docs preview:
https://55763--docspreview.netlify.app/microshift/latest/microshift_networking/microshift-networking.html#microshift-restart-ovnkube-master_microshift-networking
(admonition is just above if you scroll up a few lines)

Revised section titles/firewall moved to separate assembly
https://55763--docspreview.netlify.app/microshift/latest/microshift_networking/microshift-networking.html
https://55763--docspreview.netlify.app/microshift/latest/microshift_networking/microshift-firewall.html

QE review:

  • QE has approved this change.

Additional information:
Other structural and docs edits made as part of this PR do not include substantive content changes. These are for docs style and ease of user navigation.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2023 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-5274 which is a valid jira issue.

Details

In response to this:

Version(s):
4.12, 4.13

Issue:
https://issues.redhat.com/browse/OSDOCS-5274

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Other structural and docs edits made as part of this PR do not include substantive content changes. These are for docs style and ease of user navigation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 9, 2023
kalexand-rh
kalexand-rh reviewed Feb 9, 2023
View reviewed changes
kalexand-rh
kalexand-rh reviewed Feb 9, 2023
View reviewed changes
kalexand-rh
kalexand-rh reviewed Feb 9, 2023
View reviewed changes
@ShaunaDiaz ShaunaDiaz force-pushed the OSDOCS-5274 branch 2 times, most recently from 903e542 to 41bbf6a Compare February 9, 2023 18:16
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 9, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://55763--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/9108

@ShaunaDiaz ShaunaDiaz force-pushed the OSDOCS-5274 branch 2 times, most recently from d15f813 to 8523e45 Compare February 9, 2023 18:35
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2023 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-5274 which is a valid jira issue.

Details

In response to this:

Version(s):
4.12, 4.13

Issue:
https://issues.redhat.com/browse/OSDOCS-5274

Link to docs preview:
https://55763--docspreview.netlify.app/microshift/latest/microshift_networking/microshift-networking.html#microshift-restart-ovnkube-master_microshift-networking
(admonition is just above if you scroll up a few lines)

Revised section titles/firewall moved to separate assembly
https://55763--docspreview.netlify.app/microshift/latest/microshift_networking/microshift-networking.html
https://55763--docspreview.netlify.app/microshift/latest/microshift_networking/microshift-firewall.html

QE review:

  • QE has approved this change.

Additional information:
Other structural and docs edits made as part of this PR do not include substantive content changes. These are for docs style and ease of user navigation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShaunaDiaz
Copy link
Contributor Author

ShaunaDiaz commented Feb 9, 2023

@zshi-redhat and @jogeo PTAL and let me know if looks good to you.

jogeo
jogeo reviewed Feb 11, 2023
View reviewed changes
Copy link

@jogeo jogeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments about the use of the term "node".

zshi-redhat
zshi-redhat reviewed Feb 13, 2023
View reviewed changes
@ShaunaDiaz ShaunaDiaz force-pushed the OSDOCS-5274 branch 2 times, most recently from 1bb0d6e to 3a07b77 Compare February 13, 2023 18:09
@ShaunaDiaz
Copy link
Contributor Author

ShaunaDiaz commented Feb 13, 2023

@jogeo and @zshi-redhat Revised. PTAL especially at the Note.

zshi-redhat
zshi-redhat reviewed Feb 14, 2023
View reviewed changes
@ShaunaDiaz
Copy link
Contributor Author

ShaunaDiaz commented Feb 15, 2023

@jogeo and/or @zshi-redhat Are we good to lgtm this one?

zshi-redhat
zshi-redhat reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@zshi-redhat zshi-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good to me.

@zshi-redhat
Copy link
Contributor

zshi-redhat commented Feb 16, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
@ShaunaDiaz
Copy link
Contributor Author

ShaunaDiaz commented Feb 16, 2023

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 16, 2023
@opayne1 opayne1 added this to the Continuous Release milestone Feb 16, 2023
opayne1
opayne1 reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great. I just have a few pretty minor comments/suggestions.

@opayne1 opayne1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 16, 2023
@jogeo
Copy link

jogeo commented Feb 16, 2023

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2023 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-5274 which is a valid jira issue.

Details

In response to this:

Version(s):
4.12, 4.13

Issue:
https://issues.redhat.com/browse/OSDOCS-5274

Link to docs preview:
https://55763--docspreview.netlify.app/microshift/latest/microshift_networking/microshift-networking.html#microshift-restart-ovnkube-master_microshift-networking
(admonition is just above if you scroll up a few lines)

Revised section titles/firewall moved to separate assembly
https://55763--docspreview.netlify.app/microshift/latest/microshift_networking/microshift-networking.html
https://55763--docspreview.netlify.app/microshift/latest/microshift_networking/microshift-firewall.html

QE review:

  • QE has approved this change.

Additional information:
Other structural and docs edits made as part of this PR do not include substantive content changes. These are for docs style and ease of user navigation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh kalexand-rh changed the title OSDOCS-5274: Restart node when changing mtu value OSDOCS#5274: Restart node when changing mtu value Feb 16, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2023

@ShaunaDiaz: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Version(s):
4.12, 4.13

Issue:
https://issues.redhat.com/browse/OSDOCS-5274

Link to docs preview:
https://55763--docspreview.netlify.app/microshift/latest/microshift_networking/microshift-networking.html#microshift-restart-ovnkube-master_microshift-networking
(admonition is just above if you scroll up a few lines)

Revised section titles/firewall moved to separate assembly
https://55763--docspreview.netlify.app/microshift/latest/microshift_networking/microshift-networking.html
https://55763--docspreview.netlify.app/microshift/latest/microshift_networking/microshift-firewall.html

QE review:

  • QE has approved this change.

Additional information:
Other structural and docs edits made as part of this PR do not include substantive content changes. These are for docs style and ease of user navigation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 16, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2023

New changes are detected. LGTM label has been removed.

@ShaunaDiaz ShaunaDiaz changed the title OSDOCS#5274: Restart node when changing mtu value OSDOCS-5274: Restart node when changing mtu value Feb 16, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 16, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2023 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-5274 which is a valid jira issue.

Details

In response to this:

Version(s):
4.12, 4.13

Issue:
https://issues.redhat.com/browse/OSDOCS-5274

Link to docs preview:
https://55763--docspreview.netlify.app/microshift/latest/microshift_networking/microshift-networking.html#microshift-restart-ovnkube-master_microshift-networking
(admonition is just above if you scroll up a few lines)

Revised section titles/firewall moved to separate assembly
https://55763--docspreview.netlify.app/microshift/latest/microshift_networking/microshift-networking.html
https://55763--docspreview.netlify.app/microshift/latest/microshift_networking/microshift-firewall.html

QE review:

  • QE has approved this change.

Additional information:
Other structural and docs edits made as part of this PR do not include substantive content changes. These are for docs style and ease of user navigation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShaunaDiaz
Copy link
Contributor Author

ShaunaDiaz commented Feb 16, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 16, 2023
@jboxman-rh jboxman-rh merged commit cb4478f into openshift:main Feb 17, 2023
@jboxman-rh
Copy link

jboxman-rh commented Feb 17, 2023

/cherry-pick enterprise-4.13

@jboxman-rh
Copy link

jboxman-rh commented Feb 17, 2023

/cherry-pick enterprise-4.12

@jboxman-rh jboxman-rh removed the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 17, 2023
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 17, 2023
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 17, 2023

@jboxman-rh: new pull request created: #56048

Details

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 17, 2023
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 17, 2023

@jboxman-rh: new pull request created: #56049

Details

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShaunaDiaz ShaunaDiaz deleted the OSDOCS-5274 branch September 2, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

@opayne1 opayne1 opayne1 left review comments

+2 more reviewers

@zshi-redhat zshi-redhat zshi-redhat left review comments

@jogeo jogeo jogeo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@zshi-redhat zshi-redhat

@jogeo jogeo

Labels

branch/enterprise-4.12 branch/enterprise-4.13 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

9 participants

@ShaunaDiaz @openshift-ci-robot @ocpdocs-previewbot @zshi-redhat @jogeo @jboxman-rh @openshift-cherrypick-robot @kalexand-rh @opayne1