Skip to content

fix(i18n): better semantic translation #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 1 commit into from
Mar 2, 2026
Merged

fix(i18n): better semantic translation #1822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion i18n/locales/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@
"badges": {
"provenance": {
"verified": "已验证",
"verified_title": "已验证的来源",
"verified_title": "已验证来源",
"verified_via": "已验证：通过 {provider} 发布"
},
"jsr": {
Expand Down
2 changes: 1 addition & 1 deletion i18n/locales/zh-TW.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,7 @@
"badges": {
"provenance": {
"verified": "已驗證",
"verified_title": "已驗證的來源",
"verified_title": "已驗證來源",
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Align Traditional Chinese provenance wording across equivalent keys.

Line 745 uses 已驗證來源, but package.verified_provenance at Line 175 still uses 已驗證的來源. This creates inconsistent wording for the same concept in the same locale.

💡 Proposed wording alignment 
-    "verified_provenance": "已驗證的來源",
+    "verified_provenance": "已驗證來源",

"verified_via": "已驗證：透過 {provider} 發布"
},
"jsr": {
Expand Down
2 changes: 1 addition & 1 deletion lunaria/files/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,7 +750,7 @@
"badges": {
"provenance": {
"verified": "已验证",
"verified_title": "已验证的来源",
"verified_title": "已验证来源",
"verified_via": "已验证：通过 {provider} 发布"
},
"jsr": {
Expand Down
2 changes: 1 addition & 1 deletion lunaria/files/zh-TW.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,7 @@
"badges": {
"provenance": {
"verified": "已驗證",
"verified_title": "已驗證的來源",
"verified_title": "已驗證來源",
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Keep provenance wording consistent with the package label in this locale file.

Line 744 updates to 已驗證來源, while package.verified_provenance at Line 174 remains 已驗證的來源. Please align them to avoid mixed phrasing in the same UI language.

💡 Proposed wording alignment 
-    "verified_provenance": "已驗證的來源",
+    "verified_provenance": "已驗證來源",

"verified_via": "已驗證：透過 {provider} 發布"
},
"jsr": {
Expand Down
Loading