Skip to content

fix(i18n): better semantic translation#1822

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
zyyv:cn-trans
Mar 2, 2026
Merged

fix(i18n): better semantic translation#1822
danielroe merged 1 commit intonpmx-dev:mainfrom
zyyv:cn-trans

Conversation

@zyyv
Copy link
Contributor

@zyyv zyyv commented Mar 2, 2026

🔗 Linked issue

🧭 Context

📚 Description

Copilot AI review requested due to automatic review settings March 2, 2026 09:13
@vercel
Copy link

vercel bot commented Mar 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 2, 2026 9:15am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 2, 2026 9:15am
npmx-lunaria Ignored Ignored Mar 2, 2026 9:15am

Request Review

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/zh-CN.json Localization changed, will be marked as complete.
lunaria/files/zh-TW.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines the Chinese (Simplified/Traditional) i18n wording for the provenance badge title to be more concise/semantic, keeping the duplicated locale sources aligned.

Changes:

  • Update badges.provenance.verified_title in zh-TW from「已驗證的來源」to「已驗證來源」
  • Update badges.provenance.verified_title in zh-CN from「已验证的来源」to「已验证来源」
  • Apply the same wording updates in both locale trees (lunaria/files and i18n/locales) to maintain consistency

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
lunaria/files/zh-TW.json Adjusts TW translation for the provenance “verified” title to a more concise phrase.
lunaria/files/zh-CN.json Adjusts CN translation for the provenance “verified” title to a more concise phrase.
i18n/locales/zh-TW.json Mirrors the same TW string update in the primary i18n locale directory.
i18n/locales/zh-CN.json Mirrors the same CN string update in the primary i18n locale directory.

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2026

📝 Walkthrough

Walkthrough

This pull request updates Chinese localization strings across multiple locale files. Specifically, the verified provenance title under badges.provenance is modified in both simplified Chinese (zh-CN) and traditional Chinese (zh-TW) translations. The changes remove the particle character "的" from the phrases in four files: i18n/locales/zh-CN.json, i18n/locales/zh-TW.json, lunaria/files/zh-CN.json, and lunaria/files/zh-TW.json. Each file receives a single line change with no alterations to logic or structural components.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description is a template with empty sections and no concrete details about the changes, though the commit message indicates the purpose is improving semantic translation in i18n files. The author should provide specific details about why these translation changes improve semantics, which locales are affected, and any context about the translation improvements being made.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 31033e7 and 69f444d.

📒 Files selected for processing (4)
  • i18n/locales/zh-CN.json
  • i18n/locales/zh-TW.json
  • lunaria/files/zh-CN.json
  • lunaria/files/zh-TW.json

"provenance": {
"verified": "已驗證",
"verified_title": "已驗證的來源",
"verified_title": "已驗證來源",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Align Traditional Chinese provenance wording across equivalent keys.

Line 745 uses 已驗證來源, but package.verified_provenance at Line 175 still uses 已驗證的來源. This creates inconsistent wording for the same concept in the same locale.

💡 Proposed wording alignment
-    "verified_provenance": "已驗證的來源",
+    "verified_provenance": "已驗證來源",

"provenance": {
"verified": "已驗證",
"verified_title": "已驗證的來源",
"verified_title": "已驗證來源",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Keep provenance wording consistent with the package label in this locale file.

Line 744 updates to 已驗證來源, while package.verified_provenance at Line 174 remains 已驗證的來源. Please align them to avoid mixed phrasing in the same UI language.

💡 Proposed wording alignment
-    "verified_provenance": "已驗證的來源",
+    "verified_provenance": "已驗證來源",

@danielroe danielroe requested a review from 9romise March 2, 2026 09:28
@danielroe danielroe added this pull request to the merge queue Mar 2, 2026
Merged via the queue into npmx-dev:main with commit 6c54e41 Mar 2, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants