Conversation
4 tasks
Contributor
Author
|
@skjnldsv the sidebar test just seems to be flaky. Update: Oddly enough it just ran fine 3 times (after my force pushes) |
beardhatcode
force-pushed
the
fix/hash-and-query
branch
from
9ed4dda to
0785d13
Compare
Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
Without this commit cypress may sat it has created a user when that is not the case. Nextcloud returns a 200 HTTP code with a status set to "failure" Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
beardhatcode
force-pushed
the
fix/hash-and-query
branch
from
0785d13 to
abecd79
Compare
Member
Once in a while a timeout fails, I need to dive back into proper support of a after-close event for the AppSidebar component, so I can really trigger AFTER the sidebar is done collpasing :) |
skjnldsv
approved these changes
Apr 21, 2021
Member
|
Awesome pr! Thank you so much for ding this! |
Member
|
/backport to stable21 |
Member
|
/backport to stable20 |
backportbot-nextcloud
bot
added
the
backport-request
Member
|
/backport to stable19 |
|
The backport to stable20 failed. Please do this backport manually. |
|
The backport to stable19 failed. Please do this backport manually. |
Member
|
@beardhatcode if possible, could you backport this to stable20 (and possibly stable19 ?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added some tests and fixes to open files named
In a folder named
It breaks things :), when I (or someone else) has time I'll try to fix the issues as well, the audio/video player breaks with these names.
Issues to be fixed:
error box→ for other PRAdd test for failing load (to test error box)→for other PRSuggestions for making the filenames even naughtier are very welcome.
Supersedes #867