Fixes for naughty filenames#867
Closed
beardhatcode wants to merge 10 commits intonextcloud:masterfrom
Closed
Conversation
beardhatcode
changed the title
beardhatcode
force-pushed
the
fix/hash-and-query
branch
from
91048ce to
acdda92
Compare
Member
|
Thank you for this! There is a lot to cover indeed! Feel free to ping me if needed! 💪 |
Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
Without this commit cypress may sat it has created a user when that is not the case. Nextcloud returns a 200 HTTP code with a status set to "failure" Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
beardhatcode
force-pushed
the
fix/hash-and-query
branch
from
76a9c46 to
9ed4dda
Compare
Contributor
Author
|
@skjnldsv I'm ready with this, I (or someone else) will fix the double escaping issue in the error page (and make tests for it) in another PR. I fixed the issues I found with these tests. The results of the added test can be seen in the GH action. Commit 9f85553 should probably not be squashed when merging, it fixes a semi-unrelated error. Do you have any feedback? |
Member
|
It seems that some tests still fails :) Btw, because you're a member here, you can create branches here, and benefit from the integrated record of cypress testing 😉 |
4 tasks
Contributor
Author
|
Superseded by #868 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added some tests and fixes to open files named
In a folder named
It breaks things :), when I (or someone else) has time I'll try to fix the issues as well, the audio/video player breaks with these names.
Issues to be fixed:
error box→ for other PRAdd test for failing load (to test error box)→for other PRSuggestions for making the filenames even naughtier are very welcome.