Merged
Conversation
skjnldsv
added
bug
Member
Author
|
/compile amend / |
npmbuildbot-nextcloud
bot
force-pushed
the
fix/sidebar-open
branch
from
9019c96 to
0cb35c7
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
|
/compile amend / |
npmbuildbot-nextcloud
bot
force-pushed
the
fix/sidebar-open
branch
from
12cd824 to
c30fb24
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/sidebar-open
branch
from
c30fb24 to
42effa7
Compare
skjnldsv
commented
Jan 10, 2020
| } | ||
|
|
||
| this.sidebarWidth = sidebar.offsetWidth | ||
| setTimeout(() => { |
Member
Author
There was a problem hiding this comment.
we really need to bind the sidebar open to a proper Promise so that apps can await for it
Mikescops
approved these changes
Jan 10, 2020
Member
Mikescops
left a comment
Mikescops
left a comment
There was a problem hiding this comment.
Code review ok, not tested live
Member
Author
I also added some tests, you can review the videos as well (far right button) :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #328
Needs nextcloud/server#18783