Skip to content

Comments

Init OCA.Files.Sidebar right away#18783

Merged
rullzer merged 1 commit intomasterfrom
fix/sidebar/do-not-wait-domcontentloaded-for-init
Jan 10, 2020
Merged

Init OCA.Files.Sidebar right away#18783
rullzer merged 1 commit intomasterfrom
fix/sidebar/do-not-wait-domcontentloaded-for-init

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 9, 2020

Allow other apps to have the Sidebar handlers accessible right away and avoid race condition on the DOMContentLoaded event

@skjnldsv skjnldsv added 3. to review Waiting for reviews feature: file sidebar Related to the file sidebar component labels Jan 9, 2020
@skjnldsv skjnldsv added this to the Nextcloud 18 milestone Jan 9, 2020
@skjnldsv skjnldsv self-assigned this Jan 9, 2020
@skjnldsv skjnldsv force-pushed the fix/sidebar/do-not-wait-domcontentloaded-for-init branch from 8154faa to 6fde936 Compare January 9, 2020 14:59
@skjnldsv skjnldsv changed the base branch from stable18 to master January 9, 2020 14:59
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 9, 2020

/backport to stable18

@gary-kim

This comment has been minimized.

1 similar comment
@skjnldsv

This comment has been minimized.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the fix/sidebar/do-not-wait-domcontentloaded-for-init branch from 6fde936 to 2261629 Compare January 9, 2020 15:46
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 9, 2020
@rullzer rullzer merged commit e886ce7 into master Jan 10, 2020
@rullzer rullzer deleted the fix/sidebar/do-not-wait-domcontentloaded-for-init branch January 10, 2020 06:53
@backportbot-nextcloud
Copy link

backport to stable18 in #18796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: file sidebar Related to the file sidebar component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants