Fix migration from v-tooltip to native title in menu bar buttons ActionEntry#5233
Merged
juliusknorr merged 2 commits intomainfrom Jan 12, 2024
Merged
Conversation
ShGKme
commented
Jan 11, 2024
ShGKme
force-pushed
the
fix/remove-non-exist-directive-and-duplicated-computed
branch
from
4a707d0 to
7292555
Compare
ShGKme
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
nextcloud-command
force-pushed
the
fix/remove-non-exist-directive-and-duplicated-computed
branch
from
7292555 to
129456d
Compare
Member
|
No need for comiting compiled assets here, for text we automated this after the merge. |
ShGKme
force-pushed
the
fix/remove-non-exist-directive-and-duplicated-computed
branch
from
129456d to
9cfed18
Compare
Contributor
Author
|
This seems to be a regression of #5174 So should also be backported |
Contributor
Author
|
/backport to stable28 |
- Remove usage of already deleted directive v-tooltip - Fixed native title text to be the same as was used in tooltip to show shortcuts on desktop Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/remove-non-exist-directive-and-duplicated-computed
branch
from
9cfed18 to
0780eab
Compare
Contributor
Author
|
2 commits just squashed into one as they both actually fix migrating from No changes in the code. |
ShGKme
changed the title
v-tooltip to native title in menu bar buttons ActionEntry
ShGKme
force-pushed
the
fix/remove-non-exist-directive-and-duplicated-computed
branch
from
0780eab to
592252e
Compare
It is already added to prototype. Having properties (e.g. computed) for this method in instances throws exception: > The computed property "t" is already defined as a method. Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/remove-non-exist-directive-and-duplicated-computed
branch
from
592252e to
82ddbac
Compare
juliusknorr
deleted the
fix/remove-non-exist-directive-and-duplicated-computed
branch
Contributor
Author
|
Removing Returned it 🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Migration from
v-tooltipto nativetitlewas not complete in<ActionSingle>titleonNcActiontitletext🖼️ Screenshots
Duplication of
tdefinitionIn some components translation method
twas added as a computed propertyt: () => window.tor a method. But methodtis already added globally by prototype monkey-patching:Vue.prototype.t = t.It caused error. Removed as not needed.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)