feat: switch to native browser tooltips#5174
Merged
juliusknorr merged 1 commit intomainfrom Jan 4, 2024
Merged
Conversation
max-nextcloud
requested changes
Dec 29, 2023
Collaborator
max-nextcloud
left a comment
There was a problem hiding this comment.
Code looks good at first sight but I noticed some problems when trying it out:
- Session List "Active People" is not shown anymore
- Emoji Picker menubar entry has no tooltip and funny color on dark background
- edit guest user name also has color issues on dark background.
I'm not sure if the funny colors are related or not. Will try with current master and provide screen shots.
Collaborator
Collaborator
|
Funny color in guest name entry also exists on stable28. So not caused by this. |
Signed-off-by: Luka Trovic <luka@nextcloud.com>
2656067 to
1c24ead
Compare
Collaborator
|
@luka-nextcloud did you test the image insertion, active people and link picker? |
Contributor
Author
|
@max-nextcloud I have just checked again. It works well: |
juliusknorr
approved these changes
Jan 4, 2024
Member
|
/backport to stable28 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)