Restrict default permission to READ for sharebymail.#8204
Closed
Cybso wants to merge 1 commit intonextcloud:masterfrom
Closed
Restrict default permission to READ for sharebymail.#8204Cybso wants to merge 1 commit intonextcloud:masterfrom
Cybso wants to merge 1 commit intonextcloud:masterfrom
Conversation
See issue nextcloud#8186 Signed-off-by: Roland Tapken <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #8204 +/- ##
=========================================
Coverage 51.73% 51.73%
Complexity 25366 25366
=========================================
Files 1599 1599
Lines 95062 95062
Branches 1376 1376
=========================================
Hits 49185 49185
Misses 45877 45877
|
Author
|
Maybe a duplicate of the more generic approach in PR #7363 |
Member
|
@schiessle what is your take on this? I still feel we should solve this by selecting the permission before sharing. |
Member
|
And thanks again @Cybso! |
Member
|
Superseeded by #7363 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #8186: giving EDIT permissions by default to email shares can be dangerous
Signed-off-by: Roland Tapken [email protected]