Let the admin configure the default share permissions

[schiessle]

Let the admin configure the default share permissions

Possible look:

or (currently implemented)

[schiessle]

@jancborchardt please have a look at the two screenshots above. What do you prefer? Or something complete different? (It is about the "default share permissions")

[codecov]

Codecov Report

Merging #7363 into master will increase coverage by <.01%.
The diff coverage is 71.11%.

@@             Coverage Diff              @@
##             master    #7363      +/-   ##
============================================
+ Coverage     51.88%   51.89%   +<.01%     
- Complexity    25394    25396       +2     
============================================
  Files          1603     1603              
  Lines         95214    95249      +35     
  Branches       1379     1380       +1     
============================================
+ Hits          49403    49427      +24     
- Misses        45811    45822      +11

Impacted Files	Coverage Δ	Complexity Δ
lib/private/TemplateLayout.php	0% <0%> (ø)	48 <0> (ø)	⬇️
core/Controller/OCJSController.php	0% <0%> (ø)	2 <0> (ø)	⬇️
core/js/js.js	66.11% <0%> (-0.15%)	0 <0> (ø)
settings/templates/settings/admin/sharing.php	0% <0%> (ø)	0 <0> (ø)	⬇️
lib/private/Template/JSConfigHelper.php	0% <0%> (ø)	17 <0> (ø)	⬇️
core/js/shareitemmodel.js	88.14% <100%> (+0.64%)	0 <0> (ø)	⬇️
lib/private/Settings/Manager.php	65% <100%> (ø)	42 <0> (ø)	⬇️
apps/files_sharing/lib/Capabilities.php	87.8% <100%> (+0.3%)	5 <0> (ø)	⬇️
...iles_sharing/lib/Controller/ShareAPIController.php	68.34% <82.14%> (+0.65%)	156 <0> (+1)	⬆️
lib/private/Settings/Admin/Sharing.php	84% <84.21%> (-8.86%)	6 <2> (+1)
... and 3 more

[jancborchardt]

Do we still want to stick to this complicated CRUD-mechanic? I thought at some point we only do two permissions:

• Can edit
• Can reshare

[schiessle]

Since Nextcloud 13 is out I think now it is the right time to pick this up, looking forward to your reviews

[MorrisJobke]

Since Nextcloud 13 is out I think now it is the right time to pick this up, looking forward to your reviews

First of all: looking forward for your merge conflict fixes 😜 😉

[schiessle]

@MorrisJobke done... now it is your turn 😉

[jancborchardt]

What about my comment above? "Can edit", "Can reshare" should be the permissions, none other.

[schiessle]

What about my comment above? "Can edit", "Can reshare" should be the permissions, none other.

@jancborchardt I think it is a bit out of context. I'm completely open for simplifying the permissions. But this is one is just about making the default permissions configurable.

[schiessle]

waiting for a second review... Would be great to get this finally in before we have to rebase it again and again. Thanks!

[MorrisJobke]

@rullzer @nickvergessen @skjnldsv Review would be nice :)

[rullzer]

I rebased to make sure it all still works. Fails somehow. I'll look into the why....

[rullzer]

Ah was just cached stuff. Works like a charm.