Conversation
skjnldsv
requested review from
ChristophWurst,
Henni,
MorrisJobke,
irgendwie,
jancborchardt,
juliusknorr,
pixelipo and
rullzer
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
MorrisJobke
force-pushed
the
app-content-list-fixes
branch
from
3259f1a to
a1b4869
Compare
Codecov Report
@@ Coverage Diff @@
## master #7431 +/- ##
============================================
+ Coverage 51.08% 51.08% +<.01%
- Complexity 24858 24865 +7
============================================
Files 1596 1596
Lines 94590 94608 +18
Branches 1367 1367
============================================
+ Hits 48317 48335 +18
Misses 46273 46273
|
Member
|
Rebased to check if CI runs fine. |
MorrisJobke
approved these changes
Dec 11, 2017
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Tested and works - even in Edge and IE11 😉
Member
Author
|
EDIT: GO GO GO |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Member
Author
|
🙇 |
Member
|
Good stuff @skjnldsv! :) (Am currently crawling through issues after the week vacation :D) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I'm an idiot, I haven't implemented the proper scrolling of the app list... 🙈
You can test this with nextcloud/contacts#438 and make two birds with one stone by reviewing both 😝