Fit contacts list to guidelines

[skjnldsv]

After nextcloud/server#7195
Fix #448

[codecov]

Codecov Report

Merging #438 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #438      +/-   ##
=========================================
+ Coverage   15.78%   15.8%   +0.02%     
=========================================
  Files          61      61              
  Lines        1381    1379       -2     
=========================================
  Hits          218     218              
+ Misses       1163    1161       -2

Impacted Files	Coverage Δ
js/components/contact/contact_controller.js	9.09% <ø> (+1.39%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97a0a8...4d320f4. Read the comment docs.

[irgendwie]

Compatible with at least Nextcloud 12?

[skjnldsv]

@irgendwie No, patch for 12 will come in next pr :)

[skjnldsv]

Can we please get this in?

[irgendwie]

• Scrolling in the contacts list completely broken for me
• White space on the right next to the delete icon

Only for me?

[irgendwie]

see last comment

[skjnldsv]

@irgendwie nope, here as well, this is due to server, I have a patch coming asap. Don't know how I missed it....

[MorrisJobke]

Tested and works - even in Edge and IE11 😉

[skjnldsv]

Rebased for merging

[jancborchardt]

• When reducing the width, shortly before it breaks to mobile view, there’s a horizontal scrollbar.
• When the width is reduced and you click on a contact, the app-content-list briefly expands width while loading the new contact.

[skjnldsv]

When reducing the width, shortly before it breaks to mobile view, there’s a horizontal scrollbar.
When the width is reduced and you click on a contact, the app-content-list briefly expands width while loading the new contact.

Can't reproduce, still happening with latest commits from nextcloud/server#7195 ?

Fixed

[jancborchardt]

Two more strange issues:
In Firefox, for entries with only a name the avatar sometimes glitches to the top (sometimes only when zooming, sometimes jitters a bit when loading the app):

In Chrome, the app-content-list is strangely narrow for contacts which have 2 columns (censored the contact names but it’s still very narrow, see the scrollbar/divider):

[skjnldsv]

@jancborchardt this is related to the column system! :/
@irgendwie is this fixed now? With latest nc13b3?

[jancborchardt]

@skjnldsv yeah, thought so :/

@nextcloud/contacts what do you think - let's get this in for 13 and fix going forward?

[skjnldsv]

@jancborchardt can you update your review? :)

[jancborchardt]

It's ok for now but let's also get the details fixed. :)