Skip to content

Remove unneeded filter CSS statement#6523

Closed
MorrisJobke wants to merge 1 commit intomasterfrom
remove-unneeded-filter
Closed

Remove unneeded filter CSS statement#6523
MorrisJobke wants to merge 1 commit intomasterfrom
remove-unneeded-filter

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Sep 15, 2017

@MorrisJobke
Remove unneeded filter CSS statement
e0c6626 
* fixes #6408
* opacity is supported by all browsers now

https://caniuse.com/#search=opacity

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Sep 15, 2017
@MorrisJobke MorrisJobke mentioned this pull request Sep 15, 2017
Closed
@skjnldsv
Copy link
Member

skjnldsv commented Sep 15, 2017 •
edited
Loading

Nooo, it was on hold because it will break my work on #6372 and #6399 :(

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Sep 15, 2017

Nooo, it was on hold because it will break my work on #6372 and #6399 :(

Okay - then we will wait for those two :)

@codecov
Copy link

codecov bot commented Sep 15, 2017 •
edited
Loading

Codecov Report

Merging #6523 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6523      +/-   ##
============================================
- Coverage     53.44%   53.43%   -0.01%     
- Complexity    22542    22545       +3     
============================================
  Files          1408     1408              
  Lines         87206    87210       +4     
  Branches       1328     1328              
============================================
- Hits          46604    46602       -2     
- Misses        40602    40608       +6
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)
lib/private/Server.php 84.24% <0%> (-0.13%) 123% <0%> (ø)
apps/user_ldap/lib/Access.php 18.2% <0%> (-0.1%) 304% <0%> (+3%)

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 18, 2017
@skjnldsv
Copy link
Member

skjnldsv commented Sep 21, 2017

Closing in favor of 87d1d3e

@skjnldsv skjnldsv closed this Sep 21, 2017
@rullzer rullzer deleted the remove-unneeded-filter branch September 21, 2017 17:48
@MorrisJobke MorrisJobke removed this from the Nextcloud 13 milestone Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer Awaiting requested review from rullzer

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

2. developing Work in progress technical debt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove unused filter fallback on all css files

2 participants

@MorrisJobke @skjnldsv