Scss normalization

[skjnldsv]

Processus:

1. Set the variables to

$color-main-text: #e2e2e2;
$color-main-background: #242424;
$color-primary: #0082c9;
$color-primary-text: #ffffff;
$color-error: #e9322d;
$color-warning: #ffcc44;
$color-success: #46ba61;
$color-primary-element: $color-primary;

@function nc-darken($color, $value) {
  @return lighten($color, $value);
}

@function nc-lighten($color, $value) {
  @return darken($color, $value);
}

2. Browse nextcloud and detect inconsistencies! :)

This pr includes:

• Removal of the unused css filters
• More variables integrated into server
• Removal of undesired backgrounds
• Increased visibility of the settings button (fix app settings dialog visibility should be increased #2839)
• Fixed the files busy state loader (from gif to css)
• A lot of cleanups

[MorrisJobke]

Where does the $color-border comes from?

[skjnldsv]

Newly created var for all our borders in nc! :)

[skjnldsv]

It's a WIP, still haven't pushed the variables.scss 👍

[codecov]

Codecov Report

Merging #6372 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6372      +/-   ##
============================================
- Coverage     53.06%   53.06%   -0.01%     
- Complexity    22553    22567      +14     
============================================
  Files          1414     1417       +3     
  Lines         87745    87800      +55     
  Branches       1340     1340              
============================================
+ Hits          46565    46594      +29     
- Misses        41180    41206      +26

Impacted Files	Coverage Δ	Complexity Δ
apps/files_trashbin/lib/Expiration.php	90.32% <0%> (-1.62%)	29% <0%> (ø)
...av/lib/Migration/Version1004Date20170924124212.php	0% <0%> (ø)	1% <0%> (?)
...k/Middleware/Security/SameSiteCookieMiddleware.php	51.16% <0%> (ø)	12% <0%> (?)
...ty/Exceptions/LaxSameSiteCookieFailedException.php	100% <0%> (ø)	1% <0%> (?)
lib/base.php	2.91% <0%> (+0.01%)	172% <0%> (-1%)	⬇️
apps/dav/lib/CardDAV/CardDavBackend.php	85.56% <0%> (+0.03%)	89% <0%> (+1%)	⬆️
...e/AppFramework/DependencyInjection/DIContainer.php	77.72% <0%> (+0.59%)	27% <0%> (ø)	⬇️

[skjnldsv]

@nextcloud/designers what do you think of this?
@MorrisJobke @juliushaertl @jancborchardt

I always find the lack of feedback on the settings button disturbing, considering we have a unified design for all the links above :)

[jancborchardt]

@skjnldsv good call! Totally didn't occur to me :D

(I guess you are already thinking/working how to make the sidebar icons adapt to the background if in dark mode? ;) cc @juliushaertl

[skjnldsv]

@jancborchardt The switch to dark is the beginning of my whole work on the scss implementation, It never left my todo list!! :D

Look at #1692 ;)

[skjnldsv]

Rebased to latest master
Will continue the work!

[skjnldsv]

I think we're good here! :)
Please review @nextcloud/designers

[MorrisJobke]

I will review once #6607 is fixed.

[skjnldsv]

@MorrisJobke Your turn! ;)

[juliusknorr]

Changes look good and i could not find any visual issues with it. 👍

By the way, it would be awesome if you could clean up the commit history for this a bit. Either squash it into one or even better group them somehow logically together.

[skjnldsv]

@juliushaertl why? :)

[juliusknorr]

@skjnldsv In general they are fine, since they are already nicely grouped by small changes. The main issue i have with those is, that most of the commit messages won't help you to get what this commit is about, when you read them without context. Makes it kind of hard to track down issues afterwords imo. Maybe just a personal thing.

[skjnldsv]

@juliushaertl I see your point! :)
I can squash all of it since this is a simple pr!

[skjnldsv]

@juliushaertl all clear! ;)

[juliusknorr]

Awesome, thanks. 👍 that also makes it easier to review and checkout the changes.

[MorrisJobke]

But somehow JSUnit fails:

PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Renaming files Restores thumbnail when rename was cancelled FAILED
	Expected 'http://localhost/core/img/filetypes/text.svg' to equal 'http://localhost/core/img/loading.gif'.
	apps/files/tests/js/filelistSpec.js:753:13
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Moving files Restores thumbnail if a file could not be moved FAILED
	Expected 'http://localhost/core/img/filetypes/text.svg' to equal 'http://localhost/core/img/loading.gif'.
	apps/files/tests/js/filelistSpec.js:841:13
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests Copying files Restores thumbnail if a file could not be copied FAILED
	Expected 'http://localhost/core/img/filetypes/text.svg' to equal 'http://localhost/core/img/loading.gif'.
	apps/files/tests/js/filelistSpec.js:938:13
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests showFileBusyState shows spinner on busy rows FAILED
	Expected 'http://localhost/core/img/filetypes/image.svg' to equal 'http://localhost/core/img/loading.gif'.
	apps/files/tests/js/filelistSpec.js:3153:13

[skjnldsv]

Let me take a look @MorrisJobke

[skjnldsv]

@MorrisJobke Tests fixed. Let's wait for drone! 🎉

[jancborchardt]

🚀