feat: add api to get a user object without verifying they exist#57519
Merged
icewind1991 merged 1 commit intomasterfrom Jan 14, 2026
Merged
feat: add api to get a user object without verifying they exist#57519icewind1991 merged 1 commit intomasterfrom
icewind1991 merged 1 commit intomasterfrom
Conversation
icewind1991
requested review from
leftybournes,
nfebe,
salmart-dev and
yemkareems
and removed request for
a team
CarlSchwan
approved these changes
Jan 13, 2026
nickvergessen
approved these changes
Jan 13, 2026
artonge
approved these changes
Jan 13, 2026
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
get-existing-api
branch
from
5b1588a to
5924a2e
Compare
Merged
come-nc
reviewed
Jan 13, 2026
| * @return IUser | ||
| * @since 33.0.0 | ||
| */ | ||
| public function getExistingUser(string $userId, ?string $displayName = null): IUser; |
Contributor
There was a problem hiding this comment.
I would call it getLazyUser.
getExistingUser confuses me, to me it sounds like it will check that the user exists because I want to make sure it exists, not that it will skip the check because I already did it.
Member
Author
There was a problem hiding this comment.
I intentionally avoided "lazy" in the naming because that's an implementation details, from an API consumer POV the main difference is whether or not the existence is verified.
Open for other options though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current alternative is to manually create a
LazyUser, but that api isn't public. Adding a public api has been long discussed, so lets actually get one in.For 34 since api freeze for 33 has past.