Merged
Conversation
grnd-alt
force-pushed
the
chore/share-provide-get-users
branch
from
54c280c to
709e23b
Compare
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Office team
grnd-alt
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 📝 Office team
grnd-alt
force-pushed
the
chore/share-provide-get-users
branch
2 times, most recently
from
62c7981 to
22f8473
Compare
grnd-alt
requested review from
elzody,
grnd-alt and
luka-nextcloud
as code owners
grnd-alt
force-pushed
the
chore/share-provide-get-users
branch
from
22f8473 to
dfe25f2
Compare
artonge
approved these changes
Jan 15, 2026
icewind1991
requested changes
Jan 15, 2026
Member
icewind1991
left a comment
icewind1991
left a comment
There was a problem hiding this comment.
Other than the circles handling it looks good and seems to work as expected
5 tasks
icewind1991
reviewed
Jan 19, 2026
| return $member->getUserType() === Member::TYPE_USER; | ||
| }); | ||
| foreach ($members as $member) { | ||
| $user = $this->userManager->get($member->getUserId()); |
Member
There was a problem hiding this comment.
You can use IUserManager::getExistingUser here which doesn't require validating that the user exists in the user backend.
icewind1991
approved these changes
Jan 19, 2026
Member
icewind1991
left a comment
icewind1991
left a comment
There was a problem hiding this comment.
Looks good and seems to work
Signed-off-by: Julius Knorr <[email protected]>
Signed-off-by: Julius Knorr <[email protected]>
Signed-off-by: grnd-alt <[email protected]>
Signed-off-by: grnd-alt <[email protected]>
Signed-off-by: grnd-alt <[email protected]>
grnd-alt
force-pushed
the
chore/share-provide-get-users
branch
from
a799ab4 to
75172a4
Compare
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 📝 Office team
Member
Author
|
Thanks for taking over @grnd-alt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: Expose IUser object of internal DTO
chore: Implement getUsersForShare on share provider
Needs additional work for feat: add event for apps that a users share access might have changed server#57392
Required for nextcloud/server#57158