chore(CODEOWNERS): ensure every file change has at least 2 reviewers#54354
Merged
AndyScherzinger merged 1 commit intomasterfrom Aug 11, 2025
Merged
chore(CODEOWNERS): ensure every file change has at least 2 reviewers#54354AndyScherzinger merged 1 commit intomasterfrom
AndyScherzinger merged 1 commit intomasterfrom
Conversation
For proper review every PR needs 2 reviews, so every file needs at least 2 codeowners. Thus @blizzz is added for `workflowengine` as the app maintainer. Additionally added the desktop client team for changes related to them. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
Altahrim,
blizzz,
icewind1991,
nickvergessen and
sorbaugh
and removed request for
a team,
Altahrim and
icewind1991
susnux
commented
Aug 11, 2025
Contributor
Author
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Explaining what I did:
| /lib/public/OCM @nickvergessen @nextcloud/talk-backend @nextcloud/server-backend | ||
| /lib/public/Talk @nickvergessen @nextcloud/talk-backend | ||
| /lib/public/UserStatus @nickvergessen @nextcloud/talk-backend | ||
| */Notifications/* @nickvergessen @nextcloud/talk-backend |
Contributor
Author
There was a problem hiding this comment.
This is just moved up from "personal interest" as it was already Talk
| */Notifications/* @nickvergessen @nextcloud/talk-backend | ||
| /apps/workflowengine/lib @nickvergessen | ||
|
|
||
| /apps/workflowengine/lib @nickvergessen @blizzz |
Contributor
Author
There was a problem hiding this comment.
Added @blizzz (maintainer of the app) as otherwise every PR only get one review assigned which is too few for SLAs.
| /lib/public/Contacts @hamza221 @SebastianKrupinski | ||
|
|
||
| # Desktop client teamn | ||
| /apps/dav/lib/Connector/Sabre/BlockLegacyClientPlugin.php @nextcloud/desktop |
Contributor
Author
There was a problem hiding this comment.
Make it consistent with the bot assignments.
Comment on lines
+97
to
+102
| /build/integration/dav_features/caldav.feature @st3iny @SebastianKrupinski @tcitworld | ||
| /build/integration/dav_features/carddav.feature @hamza221 @SebastianKrupinski | ||
| /lib/private/Calendar @st3iny @SebastianKrupinski @tcitworld | ||
| /lib/private/Contacts @hamza221 @SebastianKrupinski | ||
| /lib/public/Calendar @st3iny @SebastianKrupinski @tcitworld | ||
| /lib/public/Contacts @hamza221 @SebastianKrupinski |
Contributor
Author
There was a problem hiding this comment.
Just some fixed indention
blizzz
approved these changes
Aug 11, 2025
AndyScherzinger
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For proper review every PR needs 2 reviews, so every file needs at least 2 codeowners. Thus @blizzz is added for
workflowengineas the app maintainer.Additionally added the desktop client team for changes related to them.
Checklist