-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
chore(CODEOWNERS): ensure every file change has at least 2 reviewers #54354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,7 +56,7 @@ package-lock.json @nextcloud/server-dependabot | |
| /apps/webhook_listeners/appinfo/info.xml @come-nc @julien-nc | ||
| /apps/workflowengine/appinfo/info.xml @blizzz @juliusknorr | ||
|
|
||
| # Frontend expertise | ||
| # Files frontend expertise | ||
| /apps/files/src* @skjnldsv @nextcloud/server-frontend | ||
| /apps/files_external/src* @skjnldsv @nextcloud/server-frontend | ||
| /apps/files_reminders/src* @skjnldsv @nextcloud/server-frontend | ||
|
|
@@ -91,17 +91,19 @@ ResponseDefinitions.php @provokateurin @nextcloud/server-backend | |
| /lib/public/OCM @nickvergessen @nextcloud/talk-backend @nextcloud/server-backend | ||
| /lib/public/Talk @nickvergessen @nextcloud/talk-backend | ||
| /lib/public/UserStatus @nickvergessen @nextcloud/talk-backend | ||
| */Notifications/* @nickvergessen @nextcloud/talk-backend | ||
|
|
||
| # Groupware | ||
| /build/integration/dav_features/caldav.feature @st3iny @SebastianKrupinski @tcitworld | ||
| /build/integration/dav_features/carddav.feature @hamza221 @SebastianKrupinski | ||
| /lib/private/Calendar @st3iny @SebastianKrupinski @tcitworld | ||
| /lib/private/Contacts @hamza221 @SebastianKrupinski | ||
| /lib/public/Calendar @st3iny @SebastianKrupinski @tcitworld | ||
| /lib/public/Contacts @hamza221 @SebastianKrupinski | ||
| # Groupware team | ||
| /build/integration/dav_features/caldav.feature @st3iny @SebastianKrupinski @tcitworld | ||
| /build/integration/dav_features/carddav.feature @hamza221 @SebastianKrupinski | ||
| /lib/private/Calendar @st3iny @SebastianKrupinski @tcitworld | ||
| /lib/private/Contacts @hamza221 @SebastianKrupinski | ||
| /lib/public/Calendar @st3iny @SebastianKrupinski @tcitworld | ||
| /lib/public/Contacts @hamza221 @SebastianKrupinski | ||
|
Comment on lines
+97
to
+102
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just some fixed indention |
||
|
|
||
| # Desktop client teamn | ||
| /apps/dav/lib/Connector/Sabre/BlockLegacyClientPlugin.php @nextcloud/desktop | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make it consistent with the bot assignments. |
||
|
|
||
| # Personal interest | ||
| */Activity/* @nickvergessen @nextcloud/server-backend | ||
| */Notifications/* @nickvergessen @nextcloud/talk-backend | ||
| /apps/workflowengine/lib @nickvergessen | ||
|
|
||
| /apps/workflowengine/lib @nickvergessen @blizzz | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added @blizzz (maintainer of the app) as otherwise every PR only get one review assigned which is too few for SLAs. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just moved up from "personal interest" as it was already Talk