fix(files): make sure mtime row is wide enough#53993
Merged
Conversation
susnux
requested review from
artonge and
sorbaugh
and removed request for
a team
susnux
added
design
Member
|
There's probably many other areas where we used this multiplication for the column width that needs adjusting |
szaimen
approved these changes
Jul 17, 2025
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
LGTM from the screenshot but didnt test
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
arturhg
pushed a commit
to arturhg/nextcloud-server
that referenced
this pull request
Jul 17, 2025
- Add comprehensive E2E tests for mtime column width fix - Test visual display and layout integrity of modification time column - Test business workflows requiring clear visibility of file modification times - Test accessibility compliance and internationalization support - Test edge cases, performance, and responsive behavior - Ensure mtime column width (2.5x row height) properly displays timestamps These tests verify that the increased mtime column width from PR nextcloud#53993 properly accommodates various date/time formats across different locales and screen sizes, supporting critical business workflows like: - Document collaboration and version tracking - Audit trail visibility for compliance - File synchronization conflict resolution - Batch operations based on modification times
arturhg
pushed a commit
to arturhg/nextcloud-server
that referenced
this pull request
Jul 17, 2025
- Add comprehensive file sharing workflow tests - Add collaboration and multi-user workflow tests - Add AI assistant integration tests - Add system processes and background job tests - Include proper test cleanup and documentation These E2E tests cover key Nextcloud business workflows including: - User-to-user and public file sharing with permissions - Collaborative folder sharing and activity tracking - AI/LLM features (text processing, translation, image generation) - Background jobs, versioning, and system maintenance - Notification processing and dashboard functionality
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As the row height was reduced this also reduced the width of the column, making it too narrow.
Checklist