Conversation
skjnldsv
requested review from
artonge,
sorbaugh and
susnux
and removed request for
a team
skjnldsv
added
enhancement
design
arturhg
pushed a commit
to arturhg/nextcloud-server
that referenced
this pull request
Jul 16, 2025
Add comprehensive E2E tests for the row height reduction changes in the Files app: - files-row-height-pr-53968.cy.ts: Tests basic row height functionality, interactions, and accessibility - drag-drop-row-height-pr-53968.cy.ts: Tests drag and drop operations with the new dimensions - visual-regression-row-height-pr-53968.cy.ts: Captures screenshots for visual regression testing - performance-edge-cases-pr-53968.cy.ts: Tests performance and edge cases with reduced row height These tests ensure that: - File rows display correctly at 50px height - Icons and text are properly sized and aligned - User interactions (click, hover, select) work as expected - Drag and drop functionality remains intact with updated preview dimensions - Performance is maintained with large file lists - Edge cases and special characters are handled properly - Visual consistency is maintained across different scenarios
marcoambrosini
approved these changes
Jul 16, 2025
susnux
approved these changes
Jul 16, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Could we instead of 44px just use --clickable-area-large to have this bound to a design variable?
Member
Author
|
Member
Author
|
/compile rebase |
skjnldsv
force-pushed
the
feat/files-row-height
branch
from
cdfa5b7 to
37f49a3
Compare
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
feat/files-row-height
branch
from
37f49a3 to
d1f0cee
Compare
Member
Author
|
/compile |
Member
Author
|
/backport d1f0cee to stable31 |
Member
Author
|
/backport d1f0cee to stable30 |
Contributor
I know but at least its one magic number less 😅 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This was referenced Jul 16, 2025
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist