fix(webauthn): Increase database column for public key id#47240
Merged
fix(webauthn): Increase database column for public key id#47240
Conversation
Contributor
Author
|
/backport to stable30 |
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable28 |
kesselb
approved these changes
Aug 14, 2024
st3iny
approved these changes
Aug 14, 2024
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
A size of 512 is what we use at twofactor_webauthn too 👍
* Resolves #34476 There is no maximum length defined in the standard, most common the length is between 128 and 200 characters, but as we store it not in plain data but base64 encoded the length can grow about 1/3. We had a regression with 'Nitrokey 3' which created IDs with 196 byte length -> 262 bytes encoded base64. So to be save we increase the size to 512 bytes. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/webauth-credentials-length
branch
from
255f44c to
b582630
Compare
Contributor
Author
|
/backport to stable28 |
2 tasks
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable30 |
2 tasks
Member
|
The version number should also be incremented to actually run the migration. I forgot to check that. # /version.php
$OC_Version = [31, 0, 0, 1]; |
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There is no maximum length defined in the standard, most common the length is between 128 and 200 characters, but as we store it not in plain data but base64 encoded the length can grow about 1/3.
We had a regression with 'Nitrokey 3' which created IDs with 196 byte length -> 262 bytes encoded base64. So to be save we increase the size to 512 bytes.
Checklist