chore: Do not lint external apps#40764
Merged
ChristophWurst merged 1 commit intomasterfrom Oct 5, 2023
Merged
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
skjnldsv
approved these changes
Oct 4, 2023
Pytal
approved these changes
Oct 5, 2023
GretaD
approved these changes
Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Running
npm run linton master scans all apps and therefore takes a long time and might format apps in unwanted ways. Moreover, if there is an incompatible eslint configin one of the apps, like Contacts, the linting errors out after ~30s.By using a short script we can build a list of apps that are part of the server repo. Lint now finishes in ~11s on my machine.
The same trick is also used for sass: #38590.
Checklist