chore: Do not sass-compile external apps#38590
Merged
ChristophWurst merged 1 commit intomasterfrom Jun 6, 2023
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
chore/sass-no-external-apps
branch
from
8737835 to
1ea2082
Compare
Member
Author
|
so |
Antreesy
approved these changes
Jun 6, 2023
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
It works for me locally: compiler ignore all the apps/directory, which are not included in .gitignore.
But Psalm static code analysis is still red, so it's up to you to decide
Member
Author
|
Psalm fails because of the hosted GitHub runners. The failure is caused by the system, not my changes. |
ChristophWurst
requested review from
julien-nc,
marcelklehr and
raimund-schluessler
marcelklehr
reviewed
Jun 6, 2023
marcelklehr
approved these changes
Jun 6, 2023
ChristophWurst
added
4. to release
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Only compile apps in this repo. Ignore ignored directories.
Discovered while rebuilding PRs that don't build on CI. I had to reset all external apps'
css/directory because of stray sass compilation.Checklist