fix OC_Image: Prevent E_WARNING from getimagesize*#36636
Merged
Conversation
Member
Author
|
/backport to stable25 |
Member
Author
|
/backport to stable24 |
artonge
approved these changes
Feb 9, 2023
come-nc
approved these changes
Feb 9, 2023
Contributor
|
/backport to stable26 |
Contributor
|
/rebase |
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
nextcloud-command
force-pushed
the
fix/oc-image-getimagesize
branch
from
11897bb to
4a2acca
Compare
Contributor
|
Cypress failure unrelated |
This was referenced Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getimagesize and its sister throw E_WARNINGs that can't be caught with try-catch. @ silences these.
see #36420 (comment)
and #35932
Checklist