fix the exif_read_data issue

[szaimen]

Fix #34958

[szaimen]

this was actually the only way how I could suppress the log message when testing with https://user-images.githubusercontent.com/12234510/205661916-3e7b14b4-6d4b-4dc2-9903-5265f95a2aee.png

[DrNanoLan89]

Ok.

[szaimen]

/backport to stable25

[simonspa]

What I find odd is that this seems to be only triggered by Android client uploads, but not when adding the exact same file via web interface. In one case, the error is thrown, in the other case EXIF data is retrieved just fine - so I guess there is still something else going on.

Nevertheless, suppressing this error seems to make sense to me.

[artonge]

Do you understand why the try/catch is not enough ?
Not a fan of silencing error like that.
Maybe changing } catch (\Exception $ex) { for } catch (\Throwable $ex) { and changing log level to info would be enough ?

[come-nc]

Do you understand why the try/catch is not enough ? Not a fan of silencing error like that. Maybe changing } catch (\Exception $ex) { for } catch (\Throwable $ex) { and changing log level to info would be enough ?

https://www.php.net/manual/function.exif-read-data.php states:

Errors of level E_WARNING and/or E_NOTICE may be raised for unsupported tags or other potential error conditions, but the function still tries to read all comprehensible information.

You cannot try/catch those errors, that goes straight to log.
The only way to catch them is to override the logger before the call, which is not practical.
From what I understand of the documentation, it does not throw because in some cases it still returns partial information.

[szaimen]

Thanks @come-nc! So good to merge?