Fix sharing expiration date handling and saving#35207
Merged
Conversation
Member
Author
|
/backport to stable25 |
artonge
approved these changes
Nov 16, 2022
Contributor
artonge
left a comment
There was a problem hiding this comment.
Nitpicks but fine otherwise :)
szaimen
requested changes
Nov 16, 2022
Contributor
szaimen
left a comment
There was a problem hiding this comment.
Works in my testing. However here we need to add date +1 since otherwise the default will not work as the current date is already reached.
skjnldsv
commented
Nov 16, 2022
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
e03248e to
bfa378f
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
bfa378f to
2b4ce7b
Compare
Member
Author
|
Pushed and ready to go! |
szaimen
approved these changes
Nov 16, 2022
Contributor
szaimen
left a comment
There was a problem hiding this comment.
Didnt test again but I trust you that it works now :)
Member
Author
Doesn't seems related, also failed on previous merges to master |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from #33915
Fix #34926
Explanations
share.expireDaterepresent the Database expiration data. Which expects aYYYY-MM-DDformatDateas valueserver/apps/files_sharing/lib/Controller/ShareAPIController.php
Line 236 in 62919ac
server/apps/files_sharing/src/mixins/SharesMixin.js
Lines 161 to 162 in e03248e