Skip to content

Replace vue2-datepicker with native date picker for share expiration dates#33915

Merged
szaimen merged 1 commit intomasterfrom
enh/33914-replace_expiration_date_picker_with_native_date_picker
Oct 10, 2022
Merged

Replace vue2-datepicker with native date picker for share expiration dates#33915
szaimen merged 1 commit intomasterfrom
enh/33914-replace_expiration_date_picker_with_native_date_picker

Conversation

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Sep 6, 2022 •
edited by szaimen
Loading

Requires

Replace vue2-datepicker with native date picker for expiration date.
Replace moment.js date with Date Object.

Resolves #33914

Wrapper new Date should be around new Date().setDate(new Date().getDate()......, because the Date is needed, not a timestamp.

@JuliaKirschenheuter JuliaKirschenheuter added the 2. developing Work in progress label Sep 6, 2022
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Sep 6, 2022
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Sep 6, 2022
Closed
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/33914-replace_expiration_date_picker_with_native_date_picker branch from 4115f93 to 7fdb9da Compare September 6, 2022 15:23
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review September 6, 2022 15:24
@ChristophWurst ChristophWurst marked this pull request as draft September 6, 2022 18:05
@AndyScherzinger AndyScherzinger added this to the Nextcloud 25 milestone Sep 12, 2022
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review September 12, 2022 14:58
@ChristophWurst ChristophWurst changed the title Replace vue2-datepicker with native date picker for expiration date. Replace vue2-datepicker with native date picker for share expiration dates Sep 12, 2022
szaimen
szaimen reviewed Sep 14, 2022
View reviewed changes
@szaimen
Copy link
Contributor

szaimen commented Sep 14, 2022

@JuliaKirschenheuter can you please fix ESLint? Afterwards I'll give it a try...
Also it seems like some sharing tests are failing...

@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@szaimen
Copy link
Contributor

szaimen commented Oct 3, 2022

lets hope that ESLINT passes now...

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Possible performance regression detected

Show Output 
1 queries added

= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  - UPDATE "oc_filecache" SET "mtime" = MAX("mtime", :dcValue1), "etag" = :dcValue3, "size" = CASE WHEN "size" > '-1' THEN MAX("size" + :dcValue4, :dcValue5) ELSE "size" END WHERE ("storage" = :dcValue2) AND ("path_hash" IN ('d41d8cd98f00b204e9800998ecf8427e', '45b963397aa40d4a0063e0d85e4fe7a1'))
  + UPDATE "oc_filecache" SET "mtime" = MAX("mtime", :dcValue1), "etag" = :dcValue3 WHERE ("storage" = :dcValue2) AND ("path_hash" IN ('d41d8cd98f00b204e9800998ecf8427e', '45b963397aa40d4a0063e0d85e4fe7a1'))
  + UPDATE "oc_filecache" SET "size" = MAX("size" + :dcValue1, :dcValue2) WHERE ("storage" = :dcValue3) AND ("path_hash" IN ('d41d8cd98f00b204e9800998ecf8427e', '45b963397aa40d4a0063e0d85e4fe7a1')) AND ("size" > '-1')
= /remote.php/dav/files/test/new_file.txt

szaimen
szaimen reviewed Oct 3, 2022
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Possible performance regression detected

Show Output 
1 queries added

= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  - UPDATE "oc_filecache" SET "mtime" = MAX("mtime", :dcValue1), "etag" = :dcValue3, "size" = CASE WHEN "size" > '-1' THEN MAX("size" + :dcValue4, :dcValue5) ELSE "size" END WHERE ("storage" = :dcValue2) AND ("path_hash" IN ('d41d8cd98f00b204e9800998ecf8427e', '45b963397aa40d4a0063e0d85e4fe7a1'))
  + UPDATE "oc_filecache" SET "mtime" = MAX("mtime", :dcValue1), "etag" = :dcValue3 WHERE ("storage" = :dcValue2) AND ("path_hash" IN ('d41d8cd98f00b204e9800998ecf8427e', '45b963397aa40d4a0063e0d85e4fe7a1'))
  + UPDATE "oc_filecache" SET "size" = MAX("size" + :dcValue1, :dcValue2) WHERE ("storage" = :dcValue3) AND ("path_hash" IN ('d41d8cd98f00b204e9800998ecf8427e', '45b963397aa40d4a0063e0d85e4fe7a1')) AND ("size" > '-1')
= /remote.php/dav/files/test/new_file.txt

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/33914-replace_expiration_date_picker_with_native_date_picker branch from 23ecf28 to 74b3079 Compare October 4, 2022 09:46
@ChristophWurst
Copy link
Member

ChristophWurst commented Oct 4, 2022

Last rebase dropped the bundle updates.

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/33914-replace_expiration_date_picker_with_native_date_picker branch from 74b3079 to 56c8106 Compare October 4, 2022 11:37
@ChristophWurst
Copy link
Member

ChristophWurst commented Oct 6, 2022

/compile amend /

@JuliaKirschenheuter @nextcloud-command
Replace moment.js date with Date Object.
1eac730 
Replace vue2-datepicker with native date picker for expiration date.

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the enh/33914-replace_expiration_date_picker_with_native_date_picker branch from 56c8106 to 1eac730 Compare October 6, 2022 08:56
@ChristophWurst
Copy link
Member

ChristophWurst commented Oct 7, 2022 

# FilesAppSharingContext::iSetTheShareWithAsNotEditable()
Share with user0 menu in the details view in Files app could not be found after 100 seconds

https://drone.nextcloud.com/nextcloud/server/24192/57/4

@ChristophWurst
Copy link
Member

ChristophWurst commented Oct 7, 2022

The acceptance tests also fail in other PRs -> unrelated

ChristophWurst
ChristophWurst approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@JuliaKirschenheuter JuliaKirschenheuter added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 7, 2022
@nickvergessen nickvergessen mentioned this pull request Oct 7, 2022
Open
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 7, 2022
@szaimen
Copy link
Contributor

szaimen commented Oct 10, 2022

CI failure unrelated

@szaimen szaimen merged commit cf5bf30 into master Oct 10, 2022
@szaimen szaimen deleted the enh/33914-replace_expiration_date_picker_with_native_date_picker branch October 10, 2022 07:21
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Oct 10, 2022

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 10, 2022
Merged
@szaimen szaimen mentioned this pull request Oct 11, 2022
Closed
@PVince81 PVince81 mentioned this pull request Nov 16, 2022
Closed
13 tasks
@skjnldsv skjnldsv mentioned this pull request Nov 16, 2022
Merged
@joshtrichards joshtrichards mentioned this pull request May 23, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@szaimen szaimen Awaiting requested review from szaimen

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

Replace expiration date picker with native date picker

9 participants

@JuliaKirschenheuter @szaimen @ChristophWurst @nickvergessen @skjnldsv @CarlSchwan @marcoambrosini @AndyScherzinger @blizzz