Remove dead code from checking core/apps before upgrades#24384
Merged
MorrisJobke merged 1 commit intomasterfrom Mar 17, 2021
Merged
Remove dead code from checking core/apps before upgrades#24384MorrisJobke merged 1 commit intomasterfrom
MorrisJobke merged 1 commit intomasterfrom
Conversation
juliusknorr
requested review from
ChristophWurst,
blizzz,
nickvergessen and
rullzer
ChristophWurst
approved these changes
Nov 26, 2020
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Focused so much on the emojis that I forgot to switch to approve
Member
|
Ci is not happy:
|
juliusknorr
force-pushed
the
cleanup/remove-old-migration-check
branch
from
c477686 to
f072127
Compare
rullzer
approved these changes
Dec 9, 2020
Member
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
Rebase and squash the fixup. Then good to go i think
juliusknorr
force-pushed
the
cleanup/remove-old-migration-check
branch
from
f072127 to
1c2a9b4
Compare
juliusknorr
force-pushed
the
cleanup/remove-old-migration-check
branch
from
1c2a9b4 to
24c17f5
Compare
Member
|
a lot of conflicts have appeared |
Member
|
Let me rebase |
MorrisJobke
force-pushed
the
cleanup/remove-old-migration-check
branch
from
24c17f5 to
b050736
Compare
Member
|
Rebased 👍 |
MorrisJobke
added
4. to release
Signed-off-by: Julius Härtl <jus@bitgrid.net>
MorrisJobke
force-pushed
the
cleanup/remove-old-migration-check
branch
from
b050736 to
a2f3077
Compare
Member
|
Fixed the CS complaint (was an unused |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All those methods were not called for a long time, basically since the check for db migration of core and apps was dropped in #1549 (Nextcloud 11)