[stable11] popovermenu backport#3286
Merged
LukasReschke merged 3 commits intostable11from Feb 10, 2017
Merged
Conversation
skjnldsv
requested review from
ChristophWurst,
LukasReschke,
MorrisJobke and
jancborchardt
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
popover-backport
branch
from
36c0927 to
9e7afbf
Compare
10 tasks
Member
Author
|
@nextcloud/designers bump |
Codecov Report
@@ Coverage Diff @@
## stable11 #3286 +/- ##
============================================
+ Coverage 57.13% 57.14% +<.01%
============================================
Files 1206 1206
Lines 72718 72718
Branches 1235 1235
============================================
+ Hits 41550 41553 +3
+ Misses 31168 31165 -3
Continue to review full report at Codecov.
|
Member
Author
|
Bump? 🐤 |
Member
|
Backporting this will break all apps that use this? |
Member
Author
|
@nickvergessen no it should not change a thing since most of the app were sort of close to the css guidelines. But it will greatly increase compatibility between stable11 and 12 for the popover! :) |
LukasReschke
approved these changes
Feb 10, 2017
Member
LukasReschke
left a comment
LukasReschke
left a comment
There was a problem hiding this comment.
I'd say let's merge it for now and if we see massive problems in the RC we can revert it again.
Member
Author
|
Youhouuu! :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of the corrected popovermenu.
Main ref: #3024 #3118 #3035
Additional ref: nextcloud/contacts#101
Tests: file action popover, calendar popover, user personal info privacy popover, mail account popover...
@nextcloud/designers