Skip to content

Apps scss optimisation#3024

Merged
skjnldsv merged 8 commits intomasterfrom
apps-scss-optimisation
Jan 13, 2017
Merged

Apps scss optimisation#3024
skjnldsv merged 8 commits intomasterfrom
apps-scss-optimisation

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 11, 2017 •
edited
Loading

Optimisation and simplification of the apps.scss file

  • Popover unification (see [styleguide] Popover menu #2798)
    • Unification
    • Added left/center positionning
    • Comments
    • Cleanup
  • Fusion of similar properties
  • Comments
  • Cleanup

@nextcloud/designers
Developer manual will be updated shortly

@skjnldsv skjnldsv added 2. developing Work in progress design Design, UI, UX, etc. enhancement feature: scss labels Jan 11, 2017
@skjnldsv skjnldsv self-assigned this Jan 11, 2017
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 11, 2017
@skjnldsv
popover menu restructuration & unification
2d56cce 
fix #2798

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Quote fix
5b4d5ab 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Comments and cleanup
3e36899 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copyright
735423e 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Second optimisation and readability
c87d487 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the apps-scss-optimisation branch from 2728e6e to c87d487 Compare January 11, 2017 13:05
@skjnldsv skjnldsv added this to the Nextcloud 12.0 milestone Jan 11, 2017
ChristophWurst
ChristophWurst previously requested changes Jan 11, 2017
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaks the account popover in Mail (the one in the sidebar left)

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 11, 2017
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 11, 2017 •
edited
Loading

@ChristophWurst you mean the alignment on the right?

Also, the menu doesn't fit our css guidelines. You should have an horizontal menu with the icons.
using ul >li and repeating the ul isn't a good way to do so. :)

@skjnldsv
Fix padding if empty button
dda4b3b 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 11, 2017

@ChristophWurst Okay, fixed.

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Jan 11, 2017
@skjnldsv skjnldsv removed the 2. developing Work in progress label Jan 11, 2017
@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 11, 2017

Also, the menu doesn't fit our css guidelines. You should have an horizontal menu with the icons.
using ul >li and repeating the ul isn't a good way to do so. :)

fix it 😉

@skjnldsv
App-navigation action layout fix
67c4f3d 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv mentioned this pull request Jan 11, 2017
Merged
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 11, 2017

@ChristophWurst Done 😆

@skjnldsv skjnldsv mentioned this pull request Jan 11, 2017
Merged
@codecov-io
Copy link

codecov-io commented Jan 11, 2017 •
edited
Loading

Current coverage is 54.05% (diff: 100%)

Merging #3024 into master will increase coverage by 0.13%

@@             master      #3024   diff @@
==========================================
  Files          1302       1302          
  Lines         80061      80403   +342   
  Methods        7902       7977    +75   
  Messages          0          0          
  Branches       1245       1245          
==========================================
+ Hits          43171      43461   +290   
- Misses        36890      36942    +52   
  Partials          0          0

Powered by Codecov. Last update bc26f78...ce9c833

MorrisJobke
MorrisJobke approved these changes Jan 13, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good 👍

@skjnldsv
App navigation utils button fix
ce9c833 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 13, 2017
@skjnldsv skjnldsv merged commit 8d8aff1 into master Jan 13, 2017
@skjnldsv skjnldsv deleted the apps-scss-optimisation branch January 13, 2017 15:31
This was referenced Jan 24, 2017
Closed
Closed
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 16, 2017
Closed
3 tasks
@raimund-schluessler raimund-schluessler mentioned this pull request Feb 16, 2017
Closed
@skjnldsv skjnldsv mentioned this pull request Feb 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@Henni Henni Awaiting requested review from Henni

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. feature: scss

Projects

None yet

Milestone

Nextcloud 12.0

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @ChristophWurst @codecov-io @MorrisJobke