Migrate deprecated tooltip methods#28816
Merged
CarlSchwan merged 1 commit intomasterfrom Sep 30, 2021
Merged
Conversation
nextcloud-command
force-pushed
the
fix/deprecated-toolip-methods
branch
from
cc9e785 to
55ca93a
Compare
nextcloud-command
force-pushed
the
fix/deprecated-toolip-methods
branch
from
55ca93a to
bed3691
Compare
MichaIng
force-pushed
the
fix/deprecated-toolip-methods
branch
from
bed3691 to
66abd6c
Compare
nextcloud-command
force-pushed
the
fix/deprecated-toolip-methods
branch
from
66abd6c to
8abcc9f
Compare
MichaIng
force-pushed
the
fix/deprecated-toolip-methods
branch
2 times, most recently
from
07e2275 to
c59d3f8
Compare
nextcloud-command
force-pushed
the
fix/deprecated-toolip-methods
branch
from
c59d3f8 to
6990f8f
Compare
MichaIng
force-pushed
the
fix/deprecated-toolip-methods
branch
from
6990f8f to
a827018
Compare
Member
Author
|
/compile amend / |
nextcloud-command
force-pushed
the
fix/deprecated-toolip-methods
branch
from
a827018 to
fe6f541
Compare
With Bootstrap v4, the tooltip methods "fixTitle" and "destroy" have been removed. Only core/src/Polyfill/tooltip.js keeps them methods valid by translating them. Signed-off-by: MichaIng <micha@dietpi.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
MichaIng
force-pushed
the
fix/deprecated-toolip-methods
branch
from
fe6f541 to
3a36984
Compare
Pytal
approved these changes
Sep 30, 2021
CarlSchwan
approved these changes
Sep 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Bootstrap v4, the tooltip methods
fixTitleanddestroyhave been removed. Only core/src/Polyfill/tooltip.js keeps them methods valid by translating them.The issue came up as part of the Bootstrap v5 migration: #28346
While those tooltip methods were removed with Bootstrap v4 already, the above PR currently breaks the polyfill. While the polyfill needs to be fixed when bumping Bootstrap to v5, the deprecated tooltip methods are hereby fixed separately.