Bump bootstrap from 4.6.0 to 5.1.0

[dependabot]

Bumps bootstrap from 4.6.0 to 5.1.0.

Release notes

Sourced from bootstrap's releases.

v5.1.0

Highlights

• Added experimental, opt-in CSS Grid support
• Added support for responsive offcanvas components in navbars
• Added new placeholders component for skeleton loading screens
• Added support for horizontal collapsing in the collapse component
• Added new stack and vertical rule helpers
• Added tons of new CSS variables for body styles, colors, RGB colors, and more
• Updated .bg-* and .text-* utilities to use CSS variables and new RGB CSS variables for real-time customization
• Added four new component examples for dropdowns, footers, list groups, and modals
• Updated modal and offcanvas backdrops to make them unique to each component
• Reverted ability for .col-* classes to override .row-cols-* classes for now until we can fix some critical bugs

🚀 Features

• #31813: Add optional CSS grid
• #31859: Add a "skeletons" component
• #32319: Add maps for all colors, document how to extend color utilities
• #33403: modal: change data-dismiss so that it can be outside of a modal using bs-target
• #33781: Add utility classes for opacity
• #33986: New helpers: .hstack, .vstack, and .vr
• #34253: Add horizontal collapse support
• #34273: Offcanvas navbar
• #34333: Accept argument of different types in the getInstance method

🎨 CSS

• #31813: Add optional CSS grid
• #32319: Add maps for all colors, document how to extend color utilities
• #33781: Add utility classes for opacity
• #33986: New helpers: .hstack, .vstack, and .vr
• #34100: Updated utility API (css-vars utils and new bg/color utils), plus new root CSS variables
• #34253: Add horizontal collapse support
• #34273: Offcanvas navbar
• #34432: More concise improvements for add() and subtract()
• #34440: Add null $card-box-shadow variable
• #34445: fix(forms): prevent color control from shrinking
• #34475: Make text decoration consistent with other anchors
• #34481: Make the $accordion-icon-color default value consistent with the $accordion-button-color
• #34572: Clean up a couple CSS Grid issues
• #34612: Revert "Allow individual grid classes to override .row-cols"
• #34651: Update $input-bg to use $body-bg

☕️ JavaScript

• #33402: Changes to Alert component to match the others
• #33403: modal: change data-dismiss so that it can be outside of a modal using bs-target
• #33603: Fix Manipulator.offset()
• #33610: Toasts: Change showing timings and classes to keep toast display:none by default

... (truncated)

Commits

• f20fece Prepare v5.1.0. (#34674)
• 7fcc2f4 _navbar.scss: switch comment (#34677)
• 68ff5c9 Bump @​popperjs/core from 2.9.2 to 2.9.3 (#34668)
• 0da7d66 Bump hugo-bin from 0.74.1 to 0.75.0 (#34669)
• 999eee6 Bump sass from 1.37.2 to 1.37.5 (#34670)
• 1e9446c Update .bundlewatch.config.json
• 7409271 Document the utility API's new css-var boolean
• 4d7911a Add and document additional :root CSS variables
• e72916e Update color and background-color utilities
• a2f92d1 Improved docs describing media-breakpoint-down breakpoints (#34637)
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[szaimen]

@dependabot recreate

[szaimen]

/compile amend /

[szaimen]

Node/jsunit is failing

[MichaIng]

tooltip('fixTitle') doesn't exist anymore, actually already since Bootstrap v4: https://stackoverflow.com/a/34541073/16145737

The error should be caught by the tooltip polyfill/override: https://github.com/nextcloud/server/blob/3e624dc/core/src/Polyfill/tooltip.js#L36-L41
Not sure why it does not work anymore?

---

EDIT: Using _fixTitle instead still seems to be the solution for bootstrap v5: mistic100/jQuery-QueryBuilder#432 (comment)
I'm going to replace the deprecated calls now.

[MichaIng]

Next error:

OCA.Files.NewFileMenu
New file/folder
✗ prevents entering invalid file names
TypeError: TOOLTIP: Option "container" provided type "null" but expected type "(string|element|boolean)".

seems to be here: https://github.com/nextcloud/server/blob/3e70762/apps/files/js/newfilemenu.js#L140

A string is provided, also the unexpected single quotes have no effect on the generated core/js/dist/main.js:

A.tooltip({placement:"right",trigger:"manual",container:".newFolderMenu"}),A.tooltip("_fixTitle"),A.tooltip("show")

Here the code of the two failing tests: https://github.com/nextcloud/server/blob/9de329/apps/files/tests/js/newfilemenuSpec.js#L76-L91
So it's definitely the above linked code which leads to the failure. The only other idea I have is that no element with class newFolderMenu was found, and that the selector is hence resolved first before the type checked.

---

Since Bootstrap v5 does not depend in jQuery anymore, the docs about how to use methods has change accordingly: https://getbootstrap.com/docs/5.1/components/tooltips/#methods
This makes me think whether they may behave somehow differently when being used on jQuery elements/selectors or whether there is some interference with the jQuery-UI tooltips implementation. And prototype is a jQuery thing, isn't it? So probably the polyfill $.prototype.tooltip = (function(tooltip) { is not the correct way anymore to override it?

[dependabot]

A newer version of bootstrap exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

[MichaIng]

I'll do the fixTitle => _fixTitle update in a separate PR as it is actually not related to Bootstrap v5, so the bot can re-create with the new version. What needs to be done here is:

1. Fixing the tooltip polyfill to avoid breaking fixTitle => _fixTitle update for apps which did not change it yet.
2. Investigate why "container" provided type "null" is thrown when the container attribute is clearly passed with a string.

[MichaIng]

Separate PR for tooltip methods migration: #28816

[MichaIng]

@dependabot recreate

[dependabot]

Superseded by #28817.