extend ILDAPProvider to allow reading arbitrairy ldap attributes for users#25128
Merged
extend ILDAPProvider to allow reading arbitrairy ldap attributes for users#25128
Conversation
blizzz
requested changes
Jan 14, 2021
…users Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
ldapprovider-get-property
branch
from
5ba53d7 to
fdc8635
Compare
Member
Author
|
@blizzz done |
MorrisJobke
reviewed
Jan 22, 2021
MorrisJobke
approved these changes
Jan 22, 2021
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Code looks good, but some tests would be nice.
Member
|
/backport to stable20 |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> Co-authored-by: Morris Jobke <hey@morrisjobke.de>
blizzz
approved these changes
Jan 22, 2021
Member
Mind to submit this with the new API? |
Member
|
Member
@blizzz @icewind1991 Any news here? |
Member
|
Last was #25010 (comment) |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For allowing things like #24955 using public interfaces