Revert "allow using any ldap property as login name when using login credentials"#25010
Merged
MorrisJobke merged 1 commit intomasterfrom Jan 7, 2021
Merged
Conversation
MorrisJobke
approved these changes
Jan 7, 2021
rullzer
approved these changes
Jan 7, 2021
Member
Author
|
@icewind1991 Please open a new PR with ^ taken into account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #24955
As far as I know there was no reason for merging it post feature freeze. Correct me if I am wrong.
But also, #24955 (review)