Put "Enable only for specific groups" into a new div#2491
Conversation
|
@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Henni, @nickvergessen and @jancborchardt to be potential reviewers. |
|
Tested and works 👍 cc @nextcloud/designers please review |
settings/templates/apps.php
Outdated
| <label for="groups_enable-{{id}}"><?php p($l->t('Enable only for specific groups')); ?></label> | ||
| </span> | ||
| </div> | ||
| <br /> |
There was a problem hiding this comment.
Could we get rid of this <br /> then?
|
It's an improvement. But these tiles/cards have to be redesign completely. I rebased on #2434 and the margin/padding is not right. At least some space to the |
|
@eppfel You're right! |
skjnldsv
force-pushed
the
fix-groups-enable-visual
branch
from
1e69a88 to
738fee3
Compare
|
@eppfel rebasing is fine here! :/ |
|
Yeah, the redesign will be in NC12. Think it should be more like the appstore looks now... I'll add some CSS for the spacing. Might take me till tomorrow. |
|
I was thinking to something like that |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: Felix A. Epp <work@felixepp.de>
eppfel
force-pushed
the
fix-groups-enable-visual
branch
from
738fee3 to
0d61707
Compare
|
Lets do this! 👍 |
|
@skjnldsv proposal looks like a good improvement! We only need to make sure the label »Official« doesn’t look like a button and with the checkmark like an »Enabled« state. Can you open a new issue about the improvement with Nextcloud 12 as milestone? :) |
6 participants
I think this is better looking and much cleared now.
Before
After