dont grow items in the app list

[icewind1991]

This keeps the bottom row nicely alligned

Before:

After:

cc @jancborchardt

fixes #1938

[mention-bot]

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @eppfel, @jancborchardt and @ChristophWurst to be potential reviewers.

[schiessle]

tested, works great! 👍

[schiessle]

@eppfel maybe you want to review it? Thanks!

[skjnldsv]

👎
If we have a lower resolution than a multiple of elements per rows, we get empty spaces.

[Espina2]

I agree @skjnldsv but I prefer to have more space in the right that see the elements misaligned.

[skjnldsv]

Or we could implement the code I suggested here?
http://codepen.io/kunji/pen/yNPVVb

[schiessle]

If we have a lower resolution than a multiple of elements per rows, we get empty spaces.

I'm pretty sure that this is only the case because in your example your window misses a few pixel until there is enough space for a third column. I tried it with zooming in/out of the browser window and it scaled quite well, adding/removing additional columns depending on the space on the right.

[skjnldsv]

@schiessle No no, it switch at 330px only. Flex without grow is like a float.

[schiessle]

for me this looks ok, it seems like it switches as soon as there is enough empty space for a additional column.

I consider it a improvement over what we have now...

[jancborchardt]

The current implementation looks much better on smaller screens, or iPads or whatever. We should only fix this when we can retain that layout. Otherwise we’re just switching the trade-off. 👎

@skjnldsv so do you want to implement that? :)

[skjnldsv]

@jancborchardt on it!

[eppfel]

not, yet
I think you can remove the flex, if you use percentages for the width.

[codecov-io]

Current coverage is 56.92% (diff: 100%)

Merging #2434 into master will decrease coverage by 0.20%

@@             master      #2434   diff @@
==========================================
  Files          1198       1199     +1   
  Lines         72257      73204   +947   
  Methods        7347       7494   +147   
  Messages          0          0          
  Branches       1216       1261    +45   
==========================================
+ Hits          41283      41674   +391   
- Misses        30974      31530   +556   
  Partials          0          0          

Powered by Codecov. Last update 181cf9c...f82a40d

[skjnldsv]

@jancborchardt @eppfel Done!
Please review @nextcloud/designers

I used a small backstep to 2 column when the sidebar gets hidden in mobile view!

[skjnldsv]

@eppfel I had to leave, didn't finished my work ;)

[MorrisJobke]

Works nicely 👍

[eppfel]

👍

[eppfel]

😂

[skjnldsv]

Ahahah! :D