Make share results distinguishable if there are more than one with the same display name by juliusknorr · Pull Request #23017 · nextcloud/server

juliusknorr · 2020-09-23T10:43:07Z

Give a context for users that have the same display name in the sharing input and share list
The context is the email address if set, otherwise it will fallback to the uid

Keeping current behavior if display names are different

Same display name (first two users have an email set)

Share listing

juliusknorr · 2020-09-29T11:38:54Z

@jancborchardt Could you maybe give me some input here? Having the additional bottom line is not ideal as we usually have user status there now, though it is not yet implemented in the sharing autocomplete dialog.

jancborchardt · 2020-09-29T13:45:03Z

@jancborchardt Could you maybe give me some input here? Having the additional bottom line is not ideal as we usually have user status there now, though it is not yet implemented in the sharing autocomplete dialog.

@juliushaertl Ah good point – how about putting it directly after the display name? Set as var(--color-text-maxcontrast) so it’s not so harsh. Possibly also parentheses around.

juliusknorr · 2020-09-29T14:09:56Z

Yep, sounds good, any idea about if we should show the uid or email? quick summary:

uid is unique but might be random characters on ldap setup
email might not be set for the users with the same displayname or might not be unique

jancborchardt · 2020-09-29T15:38:13Z

I would tend towards email since we don’t really use the user id often, so it’s easier to identify people by mail. If it’s not unique, then they are also the same person?

juliusknorr · 2020-09-29T16:38:56Z

If it’s not unique, then they are also the same person?

Yep indeed 😁 👍

juliusknorr · 2020-10-07T10:39:45Z

Addressed the discussion and updated the first post with details about the implementation, ready for review.

MorrisJobke

Code looks good 👍

MorrisJobke

CI fails.

MorrisJobke · 2020-10-13T16:11:41Z

/compile /

MorrisJobke · 2020-10-13T19:38:29Z

CI still fails

MorrisJobke · 2020-12-01T10:17:33Z

conflicts :(

jancborchardt

Great solution design-wise! :)

juliusknorr · 2020-12-10T17:16:12Z

Rebased and rebuilt.

juliusknorr · 2020-12-10T17:16:42Z

/backport to stable20

juliusknorr · 2020-12-10T17:17:06Z

/backport to stable19

juliusknorr · 2020-12-10T17:17:12Z

/backport to stable18

…e exact same display name Signed-off-by: Julius Härtl <jus@bitgrid.net>

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr · 2020-12-14T10:16:12Z

Resolved again

Fixed.

backportbot-nextcloud · 2020-12-14T15:57:32Z

The backport to stable20 failed. Please do this backport manually.

backportbot-nextcloud · 2020-12-14T16:01:19Z

The backport to stable19 failed. Please do this backport manually.

backportbot-nextcloud · 2020-12-14T16:04:17Z

The backport to stable18 failed. Please do this backport manually.

skjnldsv · 2021-03-11T09:32:13Z

apps/files_sharing/src/models/Share.js

 			|| this.#share.share_with
 	}

+	get shareWithDisplayNameUnique() {


Tss tss tss @juliushaertl , no documentation? 😁 🙈

juliusknorr added 3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: sharing labels Sep 23, 2020

juliusknorr added this to the Nextcloud 21 milestone Sep 23, 2020

juliusknorr added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 23, 2020

juliusknorr force-pushed the enh/distinguish-users branch from ebfd85a to 7d52b9a Compare October 7, 2020 10:33

juliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 7, 2020

juliusknorr requested review from ChristophWurst, MorrisJobke, jancborchardt and skjnldsv October 7, 2020 10:39

MorrisJobke approved these changes Oct 7, 2020

View reviewed changes

ChristophWurst approved these changes Oct 7, 2020

View reviewed changes

MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 7, 2020

MorrisJobke previously requested changes Oct 7, 2020

View reviewed changes

juliusknorr force-pushed the enh/distinguish-users branch 2 times, most recently from 3afa35c to d78d2d4 Compare October 13, 2020 14:54

juliusknorr force-pushed the enh/distinguish-users branch from b5d99c9 to bcae605 Compare October 16, 2020 13:27

tobiasKaminsky mentioned this pull request Nov 27, 2020

Make share results distinguishable if there are more than one with the same display name #24407

Open

4 tasks

jancborchardt approved these changes Dec 10, 2020

View reviewed changes

juliusknorr force-pushed the enh/distinguish-users branch from fa58ce7 to 3e7935c Compare December 10, 2020 17:16

juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 10, 2020

rullzer mentioned this pull request Dec 14, 2020

21 beta2 #24685

Merged

59 tasks

juliusknorr added 4 commits December 14, 2020 11:14

Make share results distinguishable if there are more than one with th…

a86746e

…e exact same display name Signed-off-by: Julius Härtl <jus@bitgrid.net>

Show unique displayname context in the sharing input

131fcac

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Show unique displayname context in the user share list entries

102402b

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Bump bundles

8b13fd4

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr force-pushed the enh/distinguish-users branch from 3e7935c to 8b13fd4 Compare December 14, 2020 10:16

juliusknorr merged commit b56d7f9 into master Dec 14, 2020

juliusknorr deleted the enh/distinguish-users branch December 14, 2020 15:54

juliusknorr removed the backport-request label Dec 29, 2020

skjnldsv reviewed Mar 11, 2021

View reviewed changes

nickvergessen mentioned this pull request May 3, 2022

Expose shareWithDisplayNameUnique also on autocomplete endpoint #32249

Merged

nickvergessen mentioned this pull request May 10, 2022

Add email address or username below name when adding participants to a conversation group nextcloud/spreed#7284

Closed

Uh oh!

Conversation

juliusknorr commented Sep 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Keeping current behavior if display names are different

Same display name (first two users have an email set)

Share listing

Uh oh!

juliusknorr commented Sep 29, 2020

Uh oh!

jancborchardt commented Sep 29, 2020

Uh oh!

juliusknorr commented Sep 29, 2020

Uh oh!

jancborchardt commented Sep 29, 2020

Uh oh!

juliusknorr commented Sep 29, 2020

Uh oh!

juliusknorr commented Oct 7, 2020

Uh oh!

MorrisJobke left a comment

Choose a reason for hiding this comment

Uh oh!

MorrisJobke left a comment

Choose a reason for hiding this comment

Uh oh!

MorrisJobke commented Oct 13, 2020

Uh oh!

MorrisJobke commented Oct 13, 2020

Uh oh!

MorrisJobke commented Dec 1, 2020

Uh oh!

jancborchardt left a comment

Choose a reason for hiding this comment

Uh oh!

juliusknorr commented Dec 10, 2020

Uh oh!

juliusknorr commented Dec 10, 2020

Uh oh!

juliusknorr commented Dec 10, 2020

Uh oh!

juliusknorr commented Dec 10, 2020

Uh oh!

juliusknorr commented Dec 14, 2020

Uh oh!

backportbot-nextcloud bot commented Dec 14, 2020

Uh oh!

backportbot-nextcloud bot commented Dec 14, 2020

Uh oh!

backportbot-nextcloud bot commented Dec 14, 2020

Uh oh!

skjnldsv Mar 11, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

juliusknorr commented Sep 23, 2020 •

edited

Loading