Show changelog in apps management

[juliusknorr]

This will use the changelog provided by the most recent app store release and show it in the apps management sidebar if available.

Besides that I also did some code cleanup, migrated to use the new sidebar tabs for description/changelog and removed the list transition which had quite a negative performance impact when searching and switching between app categories.

With a changelog:

Without a changelog:

[jancborchardt]

Very nice! Only minor thing is that we should call it "What’s new" instead of "Changelog" which is a bit bland and technical. :)

[GretaD]

tested and works

[jancborchardt]

See comment for wording change (I would add it directly but somehow often the build process for the apps in core messes stuff up for me).

[rullzer]

needs a rebase and the comment from @jancborchardt addressed

[juliusknorr]

I'll wait for #18969 with the rebase since I forgot that @skjnldsv was already worked on the sidebar migration. Once that is done I'll just pick the relevant changelog changes.

[skjnldsv]

I'll wait for #18969 with the rebase since I forgot that @skjnldsv was already worked on the sidebar migration. Once that is done I'll just pick the relevant changelog changes.

Thanks! 🙇 ❤️

[jancborchardt]

Btw @juliushaertl to make it simpler and also work better on mobile, we could just put the changelog below the description/links instead of using tabs.

This is also how the Android Play store and the iOS app store essentially do it. To alleviate the case of a very long description, we can set some max-height which will expand on click – exactly like we do for the rich workspaces.

[rullzer]

@juliushaertl still something we can tackle for 20?

[juliusknorr]

Not before #18969

[skjnldsv]

Not before #18969

will dive into it again soon

[rullzer]

soooo?

[juliusknorr]

Force-pushed the changelog only changes now based on master.

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32532: failure

jsunit

Show full log

PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'No OC found'
PhantomJS 2.1.1 (Linux 0.0.0) LOG: 'JQMIGRATE: Migrate is installed, version 1.4.1'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: '$ is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'Handlebars is deprecated: please ship your own, this will be removed in Nextcloud 20'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Settings initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Sidebar initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ShareSearch initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ExternalLinkActions initialized'
PhantomJS 2.1.1 (Linux 0.0.0): Executed 847 of 850 (skipped 3) SUCCESS (14.094 secs / 13.473 secs)

mariadb10.1-php7.2

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\DAV\Tests\unit\CardDAV\CardDavBackendTest::testSearch with data set "case insensitive" ('john', array('FN'), array(), array(array('uri0', 'John Doe'), array('uri1', 'John M. Doe')))
Failed asserting that 1 is identical to 2.

/drone/src/apps/dav/tests/unit/CardDAV/CardDavBackendTest.php:746

mariadb10.4-php7.3

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testGroupDeleted with data set #1 (array(0, 'user', array()), 'user', false)
Failed asserting that actual size 0 matches expected size 1.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:2418

[skjnldsv]

desca ?

Suggested change

	id="desca"
	id="changelog"

[skjnldsv]

Minor nitpick! :)
Great job!!! 🚀 😍

[rullzer]

/compile amend /