Migrate app management settings to proper sidebar standards#18969
Merged
MorrisJobke merged 2 commits intomasterfrom Aug 14, 2020
Merged
Migrate app management settings to proper sidebar standards#18969MorrisJobke merged 2 commits intomasterfrom
MorrisJobke merged 2 commits intomasterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1bc89b4 to
05742c0
Compare
17687be to
434d2c4
Compare
This comment has been minimized.
This comment has been minimized.
434d2c4 to
a353876
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
ed8a013 to
72e32b4
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
72e32b4 to
8e7c95e
Compare
Member
Author
|
Ready to review! |
Member
Author
|
Also, might be papercuts. Please ignore and we'll fix later :) |
juliusknorr
approved these changes
Aug 14, 2020
Member
Definitely, maybe we show the management tab first for installed apps, since then you are probably no longer interested in the description. Tabs were planned for #21082 anyways |
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 31793: failuremariadb10.4-php7.3Show full logacceptance-app-files
Show full log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.