Skip to content

Fix sharing note placeholder#18771

Merged
skjnldsv merged 2 commits intostable18from
fix/18452/sharing-note-title
Jan 10, 2020
Merged

Fix sharing note placeholder#18771
skjnldsv merged 2 commits intostable18from
fix/18452/sharing-note-title

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 9, 2020

Fix #18452
Closes #18735

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug 3. to review Waiting for reviews feature: sharing feature: file sidebar Related to the file sidebar component labels Jan 9, 2020
@skjnldsv skjnldsv added this to the Nextcloud 18 milestone Jan 9, 2020
@skjnldsv skjnldsv self-assigned this Jan 9, 2020
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 9, 2020

/backport to stable18

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer
Copy link
Member

rullzer commented Jan 10, 2020

So now there is no placeholder at all?
Fine by me but just wanted to double check.

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 10, 2020

So now there is no placeholder at all?

Ah, my mistake, I thought I added one! :O

EDIT: done!

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 works like a charm ⭐

@rullzer
Copy link
Member

rullzer commented Jan 10, 2020

/compile amend /

Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the fix/18452/sharing-note-title branch from 55c3a86 to 7d9b728 Compare January 10, 2020 08:19
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 10, 2020
@skjnldsv skjnldsv merged commit 7dc3615 into stable18 Jan 10, 2020
@skjnldsv skjnldsv deleted the fix/18452/sharing-note-title branch January 10, 2020 14:48
@backportbot-nextcloud
Copy link

The backport to stable18 failed. Please do this backport manually.

@skjnldsv
Copy link
Member Author

/backport to master

@backportbot-nextcloud
Copy link

backport to master in #18814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: file sidebar Related to the file sidebar component feature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments